| Summary: | Build source jar for stilts-stomplet-server-bundle-0.1.26 | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Paul Gier <pgier> |
| Component: | Build | Assignee: | Yong Yang <yyang> |
| Status: | CLOSED EOL | QA Contact: | Petr Kremensky <pkremens> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.2.0 | CC: | dosoudil, kkhan, lgao, myarboro, yyang |
| Target Milestone: | ER2 | ||
| Target Release: | EAP 6.3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-31 08:28:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 908741 | ||
|
Description
Paul Gier
2013-10-23 02:26:28 UTC
The build in question builds using maven-bundle-plugin:2.3.5-redhat-1, which based on upstream version 2.3.5, which is incompatible with maven-source-plugin, see: https://issues.apache.org/jira/browse/FELIX-3058 Mead Build: org.projectodd.stilts-stilts-0.1.26.redhat_3-1 (https://brewweb.devel.redhat.com/buildinfo?buildID=301777) Brew Build: stilts-0.1.26-9.redhat_3.1.ep6.el6 (https://brewweb.devel.redhat.com/buildinfo?buildID=301787) Pull Request: https://github.com/jbossas/jboss-eap/pull/606 Although the source jar is generated after this fixing, but the stilts-stomplet-server-bundle.jar contains inner jars, is it an issue? Verified for EAP 6.2.0 ER7. There is jboss-eap-6.2.0.GA-maven-repository/org/projectodd/stilts/stilts-stomplet-server-bundle/0.1.26.redhat-3/stilts-stomplet-server-bundle-0.1.26.redhat-3-sources.jar in jboss-eap-6.2.0.ER7-maven-repository.zip. It contains 1 source file /org/projectodd/stilts/stomplet/bundle/StompletServerActivator.java. It's ok. But it does NOT contain sources for other jar files bundled inside of stilts-stomplet-server-bundle-0.1.26.redhat-3.jar mainly stilts-conduit-server-core-0.1.26.redhat-3.jar, stilts-conduit-server-spi-0.1.26.redhat-3.jar, stilts-stomp-api-0.1.26.redhat-3.jar, stilts-stomp-common-0.1.26.redhat-3.jar, stilts-stomplet-api-0.1.26.redhat-3.jar, stilts-stomplet-server-core-0.1.26.redhat-3.jar, stilts-stomp-server-core-0.1.26.redhat-3.jar, stilts-stomp-server-spi-0.1.26.redhat-3.jar. There isn't any source file for these jar files in the jboss-eap-6.2.0.GA-maven-repository. The mead builds generates the sources already, I don't know why the sources are missing from the mead repository. see: http://download.eng.bos.redhat.com/brewroot/repos/jb-eap-6-rhel-6-build/latest/maven/org/projectodd/stilts/stilts-stomp-server-core/0.1.26.redhat-3/stilts-stomp-server-core-0.1.26.redhat-3-sources.jar To be more specific: the problem is that sources for stilts-conduit-server-core-0.1.26.redhat-3.jar, stilts-conduit-server-spi-0.1.26.redhat-3.jar, stilts-stomp-api-0.1.26.redhat-3.jar, stilts-stomp-common-0.1.26.redhat-3.jar, stilts-stomplet-api-0.1.26.redhat-3.jar, stilts-stomplet-server-core-0.1.26.redhat-3.jar, stilts-stomp-server-core-0.1.26.redhat-3.jar, stilts-stomp-server-spi-0.1.26.redhat-3.jar are not anywhere in the maven repo zip. Ok, I think we should skip this fix for 6.2, and assign an upstream issue to determine the right fix for this in the community jars for 6.3. I'm not sure whether it's correct to put the sources from the nested jars directly in the aggregator source jar. Ok, I think we should skip this fix for 6.2, and assign an upstream issue to determine the right fix for this in the community jars for 6.3. I'm not sure whether it's correct to put the sources from the nested jars directly in the aggregator source jar. Unfortunatelly in the jboss-eap-6.3.0.ER2-maven-repository.zip there aren't any sources for bundled jars mentioned in comment 8 https://bugzilla.redhat.com/show_bug.cgi?id=1022308#c8 yet. I think this issue could be closed now. |