Bug 1022825

Summary: An incorrect command is indicated when running oo-admin-check-sources.py with diabled repo
Product: OpenShift Container Platform Reporter: Ma xiaoqiang <xiama>
Component: NodeAssignee: John W. Lamb <jolamb>
Status: CLOSED ERRATA QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.0.0CC: bleanhar, libra-onpremise-devel, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-16 09:11:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Ma xiaoqiang 2013-10-24 06:40:40 UTC 
Description of problem:
Disable a repo which is used by openshift, then run oo-admin-check-sources.py to find out the disable repo, but it is indictating an incorrect command to user.

Version-Release number of selected component (if applicable):
https://github.com/openshift/openshift-extras/tree/enterprise-2.0/admin/check-sources

How reproducible:
always

Steps to Reproduce:
1.use the following settings in /etc/rhsm/rhsm.conf:
    hostname=subscription.rhn.stage.redhat.com
    baseurl=https://cdn.rcm-qa.redhat.com 
2.register a subscription
# subscription-manager  subscribe --pool 8a99f98341c648100141d9bab4fc13b5   
3.make sure  this subscription has a disabled repo, if not, run the command
#yum-config-manager --disable jb-ews-2-for-rhel-6-server-rpms --save 
4.check the resource
#./oo-admin-check-sources.py --role=node

Actual results:
Output
NOTE: If this system will be providing the JBossEAP cartridge, re-run this command with the --role=node-eap argument
Detected installed OpenShift Enterprise version 1.2
Checking if yum-plugin-priorities is installed
Required package yum-plugin-priorities is not installed. Install the package with the following command:
# yum install yum-plugin-priorities
The required OpenShift Enterprise repositories are disabled: ['jb-ews-2-for-rhel-6-server-rpms']
Enable these repositories with the following commands:
# yum-config-manager --enablerepo=jb-ews-2-for-rhel-6-server-rpms jb-ews-2-for-rhel-6-server-rpms --save
Skipping yum priorities verification

The tool gives out the command to enable the repo, but the command does not work.
run the command given out, then re-do step 4, the result still show the jb-ews-2-for-rhel-6-server-rpms repo is disabled.
The correct command should be:
#yum-config-manager --enable jb-ews-2-for-rhel-6-server-rpms --save 
After run the command above, then re-do step 4, the result show no disabled repo.

Expected results:
Should give out correct command


Additional info:
Comment 2 John W. Lamb 2013-10-24 19:18:09 UTC 
This has been addressed in this pull request:
  https://github.com/openshift/openshift-extras/pull/108
...which has been merged into the enterprise-2.0 branch of openshift-extras.

The advice output has been changed to indicate subscription-manager instead of yum-config-manager. "subscription-manager repos --enable=repo_id" will work in the current version of RHEL against RHSM-provided repositories, but unlike yum-config-manager it will also work in future versions of RHEL where the authoritative RHSM repo configuration is stored remotely.

For non-RHN, non-RHSM repositories, the appropriate yum-configuration-manager advice is given.
Comment 3 Ma xiaoqiang 2013-10-25 02:24:51 UTC 
check it on the new version
#yum-config-manager --disable jb-ews-2-for-rhel-6-server-rpms --save 
#./oo-admin-check-sources.py --role=node 
Output:
If this system will be providing the JBossEAP cartridge, re-run this command with the --role=node-eap argument
Detected installed OpenShift Enterprise version 1.2
Checking if yum-plugin-priorities is installed
The required OpenShift Enterprise repositories are disabled: ['jb-ews-2-for-rhel-6-server-rpms']
Enable these repositories with the following commands:
# subscription-manager repos --enable=jb-ews-2-for-rhel-6-server-rpms