Bug 1022861

Summary: Suggested improvement to layout/alignment settins in form modeler
Product: [Retired] JBoss BPMS Platform 6 Reporter: Jan Hrcek <jhrcek>
Component: Form ModelerAssignee: Neus Miras <nmirasch>
Status: CLOSED CURRENTRELEASE QA Contact: Jan Hrcek <jhrcek>
Severity: low Docs Contact:
Priority: low    
Version: 6.0.0CC: nmirasch, pzapataf
Target Milestone: ER5   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:11:56 UTC Type: Enhancement
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Form properties improvement suggestions
none
Form fields predefined layout. Aligned option
none
Form fields predefined layout. Not aligned fields option
none
Form fields custom layout none

Description Jan Hrcek 2013-10-24 07:52:13 UTC
Created attachment 815658 [details]
Form properties improvement suggestions

Description of problem:
Please refactor  alignment settings in Form properties section of form modeler to make them more understandable. Currently these settings are very chaotic and unnecessarily complex.

I see the following issues:

1) 'Label fields position' sellect affects field allignment for all 3 alignment options (Default, Aligned fields, Not aligned) even though it makes sense only for 'Aligned fields' option.

2) All 3 options (Default, Aligned fields and Not aligned) work exactly the same - when they are selected, the label is displayed in place which is specified by 'Label fields position'

3) The 'Automatic' option in Label fields position has the same function as would be expected from (Not aligned or Default radio button)

I suggest the following refactoring to simpify and improve understandability of these settins (see screenshot attached)



Version-Release number of selected component (if applicable):
BPMS 6.0.0 ER4

How reproducible:
Always

Steps to Reproduce:
1. Open some form in FormModeler and go to 'Form properties.

Additional info:
I understand this is a lot of steps, but I checked, that the underlying logic is localized in one class, so the changes should not be that hard to make.

Comment 1 Neus Miras 2013-11-04 10:05:23 UTC
Created attachment 819039 [details]
Form fields predefined layout. Aligned option

Comment 2 Neus Miras 2013-11-04 10:06:06 UTC
Created attachment 819040 [details]
Form fields predefined layout. Not aligned fields option

Comment 3 Neus Miras 2013-11-04 10:06:40 UTC
Created attachment 819041 [details]
Form fields custom layout

Comment 4 Neus Miras 2013-11-04 10:10:26 UTC
In the attached images we can see the changes in the tab form properties. The select with the label disposition options and the checkbox about the alignment are hidden when the custom radio is checked.

Commits
Master
https://github.com/droolsjbpm/jbpm-form-modeler/commit/2856655d4a904213de88ee767a8d3375ff412abd

6.0.x
https://github.com/droolsjbpm/jbpm-form-modeler/commit/8d9648ac2cad1d9932ce5edd9289050752cf1df8

Comment 5 Jan Hrcek 2013-12-02 06:52:17 UTC
Ok, the the refactoring is present in BPMS 6.0.0 ER5 and is working as indented.