| Summary: | Image creation returns an empty image when the size is 0 without checking if the image is external | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Haim <hateya> | ||||
| Component: | openstack-glance | Assignee: | Flavio Percoco <fpercoco> | ||||
| Status: | CLOSED UPSTREAM | QA Contact: | Yogev Rabl <yrabl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.0 | CC: | dron, eglynn, fpercoco, yeylon, yrabl | ||||
| Target Milestone: | --- | Keywords: | OtherQA, Reopened, ZStream | ||||
| Target Release: | 5.0 (RHEL 7) | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | openstack-glance-2014.1-4.el7ost | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-06-16 08:13:30 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1070258 | ||||||
| Attachments: |
|
||||||
|
Description
Haim
2013-10-24 09:05:44 UTC
Created attachment 815707 [details]
logs
There's no error here, the message you're seeing when setting Glance log level to Debug just tells you that the store being used does not implement set_acls method, which is totally fine since that's something store-specific and glance can still operate without that method. `LOG.error` / `LOG.exception` is used when real errors occur and you'll find them in the logs, [0] for example. [0] https://github.com/openstack/glance/blob/master/glance/store/__init__.py#L666 (In reply to Flavio Percoco from comment #2) > There's no error here, the message you're seeing when setting Glance log > level to Debug just tells you that the store being used does not implement > set_acls method, which is totally fine since that's something store-specific > and glance can still operate without that method. > > `LOG.error` / `LOG.exception` is used when real errors occur and you'll find > them in the logs, [0] for example. > > [0] > https://github.com/openstack/glance/blob/master/glance/store/__init__.py#L666 Flavio, I think you miss-understood the bug, I know that there is no ERROR, this is why I opened a bug, the problem is that I would like to see an error or any indication that something is wrong if I commit an action and it fails. please revise expected results again, moving back to assigned as its indeed a bug. (In reply to Haim from comment #3) > (In reply to Flavio Percoco from comment #2) > > There's no error here, the message you're seeing when setting Glance log > > level to Debug just tells you that the store being used does not implement > > set_acls method, which is totally fine since that's something store-specific > > and glance can still operate without that method. > > > > `LOG.error` / `LOG.exception` is used when real errors occur and you'll find > > them in the logs, [0] for example. > > > > [0] > > https://github.com/openstack/glance/blob/master/glance/store/__init__.py#L666 > > Flavio, I think you miss-understood the bug, I know that there is no ERROR, > this is why I opened a bug, the problem is that I would like to see an error > or any indication that something is wrong if I commit an action and it fails. > > please revise expected results again, moving back to assigned as its indeed > a bug. I understood that. What I meant to say is that the reason of the failure here, if any, is unknown - or hidden somewhere - and that makes it impossible to report an actual error. Errors are being sent back to the client when they occur. We need to find the cause of this failure - which is what #1022911 is for, isn't it? - and report that error back - or a generic one. Again, if no error was reported is because no exception / failure occurred or it was caught and not sent back. I would rather use #1022911 to tackle this issue than having a generic bug that intends to report an error from a failure that we don't know. Am I missing something? Hey Haim, In the bug report you mentioned you're using httpd. Could you re-test this taking this[0] under consideration? [0] http://www.cberendt.de/2013/11/using-nginx-with-the-glance-api/?utm_source=rss&utm_medium=rss&utm_campaign=using-nginx-with-the-glance-api The real bug is that glance-api returns an empty iterator when the size of the image is 0. This is an issue when the image is created with `--location` and the size of it is not provided. For example: $ glance image-create --name Fedora17-image --disk-format=iso --container-format=bare --size 5 --is-public=True --location http://$IMAGE_HOST/Fedora-Live-Desktop-x86_64-19-1.iso The above command will succeed and the download of the newly created image will do as well but it won't return any data. (In reply to Flavio Percoco from comment #6) > The real bug is that glance-api returns an empty iterator when the size of > the image is 0. This is an issue when the image is created with `--location` > and the size of it is not provided. For example: > > $ glance image-create --name Fedora17-image --disk-format=iso > --container-format=bare --size 5 --is-public=True --location > http://$IMAGE_HOST/Fedora-Live-Desktop-x86_64-19-1.iso > I meant: $ glance image-create --name Fedora17-image --disk-format=iso --container-format=bare --is-public=True --location http://$IMAGE_HOST/Fedora-Live-Desktop-x86_64-19-1.iso Without the size! |