Bug 1022944

Summary:	session-migration: NPE in SubTaskDecorator.checkSubTaskStrategies as Task.subTaskStrategy is null.
Product:	[Retired] JBoss BPMS Platform 6	Reporter:	Marek Baluch <mbaluch>
Component:	jBPM Core	Assignee:	Maciej Swiderski <mswiders>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Marek Baluch <mbaluch>
Severity:	high	Docs Contact:
Priority:	medium
Version:	6.0.0
Target Milestone:	ER5
Target Release:	6.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-06 20:12:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marek Baluch 2013-10-24 10:20:38 UTC

Description of problem:
When I try to complete a task I get a NPE with the following stack:

Exception in thread "main" java.lang.NullPointerException
	at org.jbpm.services.task.subtask.SubTaskDecorator.checkSubTaskStrategies(SubTaskDecorator.java:196)
	at org.jbpm.services.task.subtask.SubTaskDecorator.complete(SubTaskDecorator.java:101)
	at org.jbpm.services.task.deadlines.DeadlinesDecorator.complete(DeadlinesDecorator.java:113)
	at org.jbpm.services.task.impl.TaskServiceEntryPointImpl.complete(TaskServiceEntryPointImpl.java:253)
	at org.jboss.qa.bpms.jbpm.LoadSessionTest.humanTaskWithTaskServiceTest(LoadSessionTest.java:257)
	at org.jboss.qa.bpms.jbpm.LoadSessionTest.main(LoadSessionTest.java:310)

The issue is caused by the update of tables from jBPM 5 to 6. The 'subTaskStrategy' column will be 'null' for all tasks.

e.g.
mysql> select subTaskStrategy from Task;
+-----------------+
| subTaskStrategy |
+-----------------+
| NULL            |
+-----------------+
1 row in set (0.00 sec)


How to reproduce:
1) Execute a process with a human task in 5.
2) Restore it in 6 and complete the task.

The 'StoreSessionTest.humanTaskWithTaskServiceTest' amd 'LoadSessionTest.humanTaskWithTaskServiceTest' in http://git.app.eng.bos.redhat.com/jbossqe/brms.git/tree/test-jbpm-session-migration can be used to reproduce the issue.

Comment 1 Marek Baluch 2013-10-24 10:22:12 UTC

I set the severity to 'High' because I believe that many customers will use the migration feature to move their processes from 5 to 6. If the feature does not work then their operation will be impacted in great extent.

Comment 2 Maciej Swiderski 2013-10-29 14:59:33 UTC

fixed to ensure the sub task strategy is checked before it's used

jbpm
master:
https://github.com/droolsjbpm/jbpm/commit/23672ee22a94ffdaed1651abb4eb1ba22cc7a0aa

6.0.x
https://github.com/droolsjbpm/jbpm/commit/ba1f9b87d6821d5f9fb71c42e6fe97d1e4082221

Comment 3 Marek Baluch 2013-12-02 11:54:31 UTC

Verified on ER5.