Bug 1022975
| Summary: | [vdsm] storage domain upgrade fails with attributeError | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Gadi Ickowicz <gickowic> | ||||||
| Component: | vdsm | Assignee: | Federico Simoncelli <fsimonce> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Gadi Ickowicz <gickowic> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 3.3.0 | CC: | abaron, amureini, bazulay, danken, dougsland, fsimonce, iheim, lpeer, nlevinki, scohen, ybronhei, yeylon | ||||||
| Target Milestone: | --- | Keywords: | Regression | ||||||
| Target Release: | 3.3.0 | Flags: | amureini:
Triaged+
|
||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | storage | ||||||||
| Fixed In Version: | is22 | Doc Type: | Bug Fix | ||||||
| Doc Text: |
The v3ResetMetaVolSize argument was changed from volume object to volume UUID, which triggered attribute errors during the execution. Consequently, upgrading a storage pool or domain from 3.0 compatibility mode to 3.1 failed. This update reintroduces volume objects as accepted arguments and correctly handles such exceptions.
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-01-21 16:19:08 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1019391, 1032811 | ||||||||
| Attachments: |
|
||||||||
|
Description
Gadi Ickowicz
2013-10-24 11:48:45 UTC
This regression was introduced in commit:
c072945 One shot prepare.
where img.prepare was replaced by sd.getVolsOfImage:
+ imgVolumes = sd.getVolsOfImage(allVolumes, imgUUID).keys()
try:
- for vol in img.prepare(domain.sdUUID, imgUUID):
+ try:
+ domain.activateVolumes(imgUUID, imgVolumes)
+ except (OSError, se.CannotActivateLogicalVolumes):
+ log.error("Image %s can't be activated.",
+ imgUUID, exc_info=True)
+
+ for vol in imgVolumes:
try:
v3ResetMetaVolSize(vol) # BZ#811880
The patch changed the v3ResetMetaVolSize argument from a volume object to the volume uuid (string), therefore triggering the attribute error, e.g.:
AttributeError: 'str' object has no attribute 'volUUID'
Created attachment 822076 [details]
vdsm logs
verified on is22 (vdsm-4.13.0-0.7.beta1.el6ev.x86_64) upgrade from 3.0 to 3.1 successful
This bug is currently attached to errata RHBA-2013:15291. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag. Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information: * Cause: What actions or circumstances cause this bug to present. * Consequence: What happens when the bug presents. * Fix: What was done to fix the bug. * Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore') Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug. For further details on the Cause, Consequence, Fix, Result format please refer to: https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes Thanks in advance. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-0040.html |