| Summary: | quota: moving files between directories does not update the size field properly | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Raghavendra G <rgowdapp> |
| Component: | quota | Assignee: | Raghavendra G <rgowdapp> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | medium | ||
| Version: | pre-release | CC: | gluster-bugs, jdarcy, pkarampu, rgowdapp, rhs-bugs, saujain, shaines, spalai, surs, vagarwal, vbellur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 871015 | Environment: | |
| Last Closed: | 2014-04-17 11:50:02 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 871015 | ||
| Bug Blocks: | |||
|
Comment 1
Anand Avati
2013-10-24 12:30:46 UTC
REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#1) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#1) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6154 (core: introduce internal fop types) posted (#1) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#2) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#2) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6154 (core: introduce internal fop types) posted (#2) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6138 (features/marker: don't honour GLUSTERFS_INTERNAL_FOP_KEY) posted (#2) for review on master by Krishnan Parthasarathi (kparthas) REVIEW: http://review.gluster.org/6138 (features/marker: don't honour GLUSTERFS_INTERNAL_FOP_KEY) posted (#3) for review on master by Krishnan Parthasarathi (kparthas) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#3) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#3) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#1) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6204 (features/marker: remove dead code in unlink codepath.) posted (#1) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#4) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#2) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#4) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6204 (features/marker: remove dead code in unlink codepath.) posted (#2) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#5) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#3) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#5) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6204 (features/marker: remove dead code in unlink codepath.) posted (#3) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#6) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#4) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#6) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#7) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#5) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#7) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#8) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#6) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#8) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#1) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#9) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#7) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#9) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#2) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#10) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#8) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#10) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#3) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#11) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#9) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#11) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6253 (tests: add EXPECT_NOT macro) posted (#4) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#28) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#26) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#28) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#29) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#27) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#29) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#30) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#28) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#30) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6153 (features/marker-quota: exclude dht-linkfiles from being accounted.) posted (#31) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6203 (cluster/dht: instruct marker whenever it shouldn't do accounting) posted (#29) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/6152 (core: add dht_is_linkfile helper procedure.) posted (#31) for review on master by Raghavendra G (rgowdapp) COMMIT: http://review.gluster.org/6152 committed in master by Anand Avati (avati) ------ commit 1a2f51144fcbd920a6f3769d6b2f3ceeefdc220d Author: Raghavendra G <rgowdapp> Date: Thu Nov 14 17:10:09 2013 +0530 core: add dht_is_linkfile helper procedure. components other than distribute (like marker to exclude linkfiles from being accounted) also need awareness of what constitutes a linkfile. Hence its good to separate out this functionality into core. Change-Id: Ib944eeacc991bb1de464c9e73ee409fc7a689ff1 BUG: 1022995 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/6152 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6153 committed in master by Anand Avati (avati) ------ commit 75f66a98dad3882aff4a68cf0648016101f0a416 Author: Raghavendra G <rgowdapp> Date: Mon Oct 28 10:32:52 2013 +0530 features/marker-quota: exclude dht-linkfiles from being accounted. Change-Id: I3239f5e8477664dcc04434e4d455ae447493a7ac BUG: 1022995 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/6153 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> COMMIT: http://review.gluster.org/6203 committed in master by Anand Avati (avati) ------ commit 33e0df30cbffbfbda5197704d0f788c83cd7ed78 Author: Raghavendra G <rgowdapp> Date: Thu Oct 31 06:35:47 2013 +0530 cluster/dht: instruct marker whenever it shouldn't do accounting This is needed for two reasons: * since dht-linkfiles are internal, they shouldn't be accounted. * hardlink handling in marker is broken. link/unlink of hardlinks present in same directory can break marker accounting. Hence, if src and dst are in same directory in case of rename, dht - if it breaks rename into link/unlink operations - should instruct marker to not to do accounting. Change-Id: I9c9f7384569f75a2792f6450ee7a5279bf751ae7 BUG: 1022995 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/6203 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anand Avati <avati> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report. glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |