Bug 1023455

Summary: [CodeChange][RFE] log-collector should use the same code used by the engine for parsing configuration
Product: [oVirt] ovirt-log-collector Reporter: Sandro Bonazzola <sbonazzo>
Component: RFEsAssignee: Douglas Schilling Landgraf <dougsland>
Status: CLOSED CURRENTRELEASE QA Contact: Pavel Novotny <pnovotny>
Severity: low Docs Contact:
Priority: medium    
Version: 3.3.0CC: bugs, dfediuck, didi, dougsland, jmoran, lsvaty, lveyde, pstehlik, rbalakri, Rhev-m-bugs, rmartins, sbonazzo, srevivo, stirabos, ylavi
Target Milestone: ovirt-4.2.0Keywords: CodeChange, FutureFeature, Improvement
Target Release: 4.2.0Flags: rule-engine: ovirt-4.2+
gklein: testing_plan_complete-
ylavi: planning_ack+
rule-engine: devel_ack+
rule-engine: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 10:46:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1456888    

Description Sandro Bonazzola 2013-10-25 13:09:05 UTC
rhevm-log-collector parse engine configuration using as default the content of
/usr/share/conf/engine.conf.defaults which doesn't exist.
The file in 3.2 was in /usr/share/ovirt-engine/conf/engine.conf.defaults and has been moved to /usr/share/ovirt-engine/services/ovirt-engine/ovirt-engine.conf in 3.3.

This error can't be detected just running it and don't have user impact because the content of the default file is not really useful for log-collector.
However it is better to use the same class for parsing conf files within all tools avoiding to be out of sync.

Comment 2 Red Hat Bugzilla Rules Engine 2017-05-24 20:55:28 UTC
This request has been proposed for two releases. This is invalid flag usage. The ovirt-future release flag has been cleared. If you wish to change the release flag, you must clear one release flag and then set the other release flag to ?.

Comment 3 Lukas Svaty 2017-09-04 10:40:26 UTC
CodeChange moving to VERIFIED

Comment 4 Sandro Bonazzola 2017-12-20 10:46:04 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.