Bug 1023601

Summary:	Review Request: ghc-aeson-pretty - JSON pretty-printing library and command-line tool
Product:	[Fedora] Fedora	Reporter:	Rick Elrod <relrod>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	haskell-devel, package-review, petersen
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	NotReady
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-27 07:26:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rick Elrod 2013-10-25 22:18:13 UTC

Spec URL: http://codeblock.fedorapeople.org/packages/aeson-pretty/aeson-pretty.spec
SRPM URL: http://codeblock.fedorapeople.org/packages/aeson-pretty/aeson-pretty-0.7-1.fc20.src.rpm
Description:
A JSON pretty-printing library compatible with aeson as well as a command-line
tool to improve readabilty of streams of JSON data.

The /library/ provides the function "encodePretty". It is a drop-in replacement
for aeson's "encode" function, producing JSON-ByteStrings for human readers.

The /command-line tool/ reads JSON from stdin and writes prettified JSON to
stdout. It also offers a complementary "compact"-mode, essentially the opposite
of pretty-printing.

Fedora Account System Username: codeblock

Comment 1 Jens Petersen 2013-10-26 11:52:32 UTC

Any idea how important the tool is?

Just wonder if it would be better to call this ghc-aeson-pretty?

Comment 2 Jens Petersen 2013-10-26 11:53:47 UTC

(Actually lately I have been pondering on the frightening idea
of renaming all the Haskell src packages to hackage-*! ;-)

Comment 3 Rick Elrod 2013-10-26 16:38:18 UTC

I'm fine with calling this ghc-aeson-pretty (or hackage-aeson-pretty :P). aeson-pretty is what cblrpm defaulted to on this though.

Should I just combine the subpackage it made (ghc-aeson-pretty) and the base package (aeson-pretty) into ghc-aeson-pretty?

Comment 4 Jens Petersen 2013-10-27 11:46:37 UTC

You can use "cblrpm -l spec" to force a BinLib package to become Lib.

Comment 5 Jens Petersen 2013-10-27 11:48:32 UTC

(Hmm perhaps cblrpm should just default all package with a library to be called ghc-*.  I might do that in the next release.)

Comment 6 Jens Petersen 2013-10-27 12:47:36 UTC

Sorry I see I didn't answer your actual question:

> Should I just combine the subpackage it made (ghc-aeson-pretty) and the base
> package (aeson-pretty) into ghc-aeson-pretty?

Hmm it probably depends on the use case of the executable.
For some packages we put the program into the devel package
because that made sense.  Another approach if it doesn't make
sense to do that or to exclude the program, might also be
to subpackage it as aeson-pretty.  (Typically for libraries that
include some test/demo program we just remove it completely.)

(Other previous examples include highlighting-kate (rename review submitted)
and ghc-derive (already renamed!).)

Comment 7 Jens Petersen 2014-01-22 05:33:30 UTC

This package is needed for pandoc-citeproc.

Do you want to update this?
Otherwise I can start a new review.

Comment 8 Jens Petersen 2014-01-27 07:26:02 UTC


*** This bug has been marked as a duplicate of bug 1058174 ***