Bug 1023606

Summary: Passing ocft unit test cases for resource-agents package
Product: Red Hat Enterprise Linux 6 Reporter: David Vossel <dvossel>
Component: resource-agentsAssignee: David Vossel <dvossel>
Status: CLOSED NEXTRELEASE QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.6CC: agk, cluster-maint, fdinitto, mnovacek
Target Milestone: rcKeywords: TestOnly
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: resource-agents-3.9.5-4.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 19:00:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
update ocft test cases none

Description David Vossel 2013-10-25 22:31:56 UTC 
Description of problem:

The resource-agents package contains a test suite for testing the ocf:heartbeat provider agents.  That test suite consists of a unit test executable 'ocft' and a set of case files that can be built and executed by the 'ocft' command.  This test suite is limited in its ability, but offers a great way of sanity checking the basic functionality of our resource-agents.

As of now however hardly any of the ocft test cases pass in a rhel environment. This is largely to do with fact that the test cases are written in a distro specific way.

We need to alter the test cases we ship so they pass in rhel.

How reproducible:
100%

Steps to Reproduce:
run the oct test suite.

1. ocft make
2. ocft test

Actual results:
tests fail

Expected results:
tests pass

Additional info:

Moving forward, it is very important that we introduce this test suite and start adding additional cases to it as we see fit.  This is another tool that will help us avoid regressions.

Note that the tests currently failing do not reflect the functionality of the agents we are shipping.  I have already updated the ocft test cases to work in rhel, during that process I found no regressions.
Comment 2 David Vossel 2013-10-25 22:36:19 UTC 
Created attachment 816297 [details]
update ocft test cases

This adds passing unit tests for the following agents

apache
Filesystem
IPaddr2
IPaddr2v4
IPaddr2v6
IPsrcaddr
IPv6addr
LVM
MailTo
mysql
named
nfsserver
pgsql
postfix
SendArp
tomcat
Xinetd
Comment 3 David Vossel 2014-06-13 19:00:15 UTC 
This was a TestOnly bug, the tests have been updated. I'm closing this.