Bug 1023642

Summary: Throw "TypeError("The type (<type 'bool'>) of OVIRT_PUPPET_ENABLED" error when disabling puppet
Product: Red Hat Enterprise Linux 6 Reporter: haiyang,dong <hadong>
Component: ovirt-nodeAssignee: Ryan Barry <rbarry>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.5CC: acathrow, bsarathy, cboyle, cshao, fdeutsch, gouyang, hadong, huiwa, jboggs, leiwang, mburns, mgoldboi, ovirt-bugs, ovirt-maint, rbarry, ycui, yeylon
Target Milestone: rcFlags: rbarry: needinfo-
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-node-3.0.1-8.el6 Doc Type: Bug Fix
Doc Text:
When disabling puppet by unchecking "Enable Puppet []", the following exception was generated:"TypeError("The type (<type 'bool'>) of OVIRT_PUPPET_ENABLED" This was caused by a logic problem in the code which is now fixed. puppet is disabled when the check bock is unchecked.
Story Points: ---
Clone Of: 1022960 Environment:
Last Closed: 2014-01-21 19:35:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1022960    
Bug Blocks:    

Description haiyang,dong 2013-10-26 12:18:48 UTC
+++ This bug was initially created as a clone of Bug #1022960 +++

Description of problem:
Using edit-node install ovirt-node-plugin-puppet into ovirt-node-iso and clean install this
iso .Login it and enter into puppet page, configure 
Puppet Server:master.example.com
Puppet Certificate Name: agent2.example.com
after clicking "Save" button to apply this configuration. check that it will configure puppet success.

But when disabling puppet via unchecked "Enable Puppet []", it will throw execption
about "TypeError("The type (<type 'bool'>) of OVIRT_PUPPET_ENABLED" error info.(Seen execption when disable puppet.png )

Version-Release number of selected component (if applicable):
ovirt-node-iso-3.1.0-0.999.1132.el6.iso
ovirt-node-plugin-puppet-3.1.0-0.999.20131024005255gitc1886e2.el6.noarch.rpm

How reproducible:
100%

Steps to Reproduce:

Actual results:


Expected results:

Comment 2 haiyang,dong 2013-10-26 12:22:25 UTC
Could reproduce this issue in downstream:
rhevh-6.5-20131024.1.0.iso
ovirt-node-plugin-puppet-3.0.1-6.el6.noarch.rpm

so need clone it from upstream to track it in rhev-h

Comment 4 haiyang,dong 2013-12-17 10:40:15 UTC
Test version:
ovirt-node-3.0.1-9.el6_5.noarch.rpm
rhevh-6.5-20131213.0.0.iso

Unslect "Enable Puppet" in puppet_page.py to disable puppet.No exception was thrown. It will stop puppet service and remove related
configuration info from "/etc/puppet/puppet.conf"

so this bug has been fixed on ovirt-node-3.0.1-9.el6_5, after the status of this bug changed into "ON_QA", I will verify it.

Comment 5 haiyang,dong 2013-12-20 02:09:09 UTC
According to comment 4 , change the status into "verified"

Comment 6 Cheryn Tan 2014-01-08 05:35:37 UTC
This bug is currently attached to errata RHBA-2013:15277. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:
https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes

Thank you for your help.

Comment 8 errata-xmlrpc 2014-01-21 19:35:54 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0033.html