Bug 1023900

Summary:	[RFE] Allow groups to be disabled
Product:	[Retired] Beaker	Reporter:	wangjing <jingwang>
Component:	web UI	Assignee:	beaker-dev-list
Status:	CLOSED DEFERRED	QA Contact:	tools-bugs <tools-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	0.14	CC:	mastyk, qwan, tools-bugs
Target Milestone:	---	Keywords:	FutureFeature, Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Cause: Consequence: Fix: Result:	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-20 08:13:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description wangjing 2013-10-28 09:42:23 UTC

Description of problem:
can't remove group

Version-Release number of selected component (if applicable):
beaker-devel Version - 0.14.1

How reproducible:
always

Steps to Reproduce:
1. Admin->Groups
2. click link 'Remove' of my group 'jingwang', and click 'Yes'.
(have deleted  all  the group jobs of 'jingwang' group)

Actual results:
message returned 'Cannot delete a group which has associated jobs'

Expected results:
remove link takes effect or proper messages returned. 

Additional info:

Comment 2 Amit Saha 2013-10-29 00:43:57 UTC

(In reply to wangjing from comment #0)
> Description of problem:
> can't remove group
> 
> Version-Release number of selected component (if applicable):
> beaker-devel Version - 0.14.1
> 
> How reproducible:
> always
> 
> Steps to Reproduce:
> 1. Admin->Groups
> 2. click link 'Remove' of my group 'jingwang', and click 'Yes'.
> (have deleted  all  the group jobs of 'jingwang' group)

Even though you deleted the job, they are not really deleted from the database. Hence, I believe this is expected behavior. 

I just verified that deleting a group works.

Comment 3 Nick Coghlan 2013-10-29 02:15:32 UTC

I thought we had an open RFE for hiding or disabling groups, but it's actually just mentioned as a deferred feature in the enhanced user group proposal: http://beaker-project.org/dev/proposals/enhanced-user-groups.html#deferred-features

We ended up creating a usable access policies UI without that ability (based on typeahead rather than a dropdown list), but it would still be good to be able to disable groups (similar to the way we can disable user accounts and lab controllers)

Comment 4 wangjing 2013-10-29 02:27:16 UTC

I think it's still a problem because it makes people feel confused when seeing message 'Cannot delete a group which has associated jobs', 

and why 'Even though you deleted the job, they are not really deleted from the database'?

I reopened this bug, if u want to close, pls close WONTFIX/DEFERRED, because *closed NOTABUG* will affect our bug efficiency.

thanks!

Comment 5 Nick Coghlan 2013-10-29 03:07:16 UTC

Converted to an RFE for the group disabling feature. We shouldn't offer the ability to delete groups at all, as the constraints on when they can actually be deleted are just too confusing.

Comment 6 Raymond Mancy 2013-10-29 10:28:42 UTC

(In reply to wangjing from comment #4)
> I think it's still a problem because it makes people feel confused when
> seeing message 'Cannot delete a group which has associated jobs', 
> 
> and why 'Even though you deleted the job, they are not really deleted from
> the database'?
> 

The user should never care whether or not the record still exists in the database. Just as long as the system behaves as if it doesn't exist.

> I reopened this bug, if u want to close, pls close WONTFIX/DEFERRED, because
> *closed NOTABUG* will affect our bug efficiency.
> 
> thanks!