| Summary: | startkde adding /bin to $PATH | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | T.C. Hollingsworth <tchollingsworth> |
| Component: | kde-workspace | Assignee: | Than Ngo <than> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | dvratil, jgrulich, jreznik, kevin, ltinkl, manisandro, mbriza, rdieter, rnovacek, than |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | kde-workspace-4.11.2-3 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-28 14:48:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
yeah, I think we can assume qdbus is in $PATH already. %changelog * Mon Oct 28 2013 Rex Dieter <rdieter> 4.11.2-3 - startkde adding /bin to $PATH (#1023999) Fix will be rolled into 4.11.3 updates coming soon. Why is this crap snippet AGAIN in our startkde? We were always patching that out (in past upstream incarnations, it would not add /bin, but the path containing the unsuffixed assistant etc., breaking the Qt 3 .desktop files), the hunk patching it out had already gone lost at least once and I had readded it. Please do not randomly drop hunks of our patches when rebasing patches, they are all there for a reason! (I'm starting to think that instead of that startkde patch that needs constant rebasing, we should just ship a cleaned startkde we control as a Source* and use that to replace the upstream junk-loaded script wholesale.) |
Looks like this snippet in startkde is adding /bin to $PATH: bindir=`echo "$0" | sed -n 's,^\(/.*\)/[^/][^/]*$,\1,p'` if [ -n "$bindir" ]; then qbindir=`$bindir/kde4-config --qt-binaries` qdbus=$qbindir/qdbus $bindir|$bindir:*|*:$bindir|*:$bindir:*) ;; *) PATH=$bindir:$PATH; export PATH;; I added an `echo $bindir > /tmp/bindir` and restarted KDE to make sure. Might be where this is coming from: https://lists.fedoraproject.org/pipermail/devel/2013-October/190776.html Please patch startkde not to do this, it confuses some applications (and users) and is rather undesirable in the post-UsrMove universe. Thanks!