Bug 1024134
Summary: | Review Request: gust-antykwa-torunska-fonts - Two-element typeface for typesetting of small prints | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Zbigniew Jędrzejewski-Szmek <zbyszek> | ||||||
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | package-review, panemade, paul | ||||||
Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | gust-antykwa-torunska-fonts-2.08-4.fc20 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2014-01-03 08:36:42 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Zbigniew Jędrzejewski-Szmek
2013-10-28 23:43:54 UTC
Suggestions: 1) good if unnecessary information is removed from font wiki page 2) generally we create wiki pages with all the words in small letter 3) why this package name starts with gust? You want to use it as foundry? If yes good to add some reference like how gust is related to this font. When I search on google, I found its related in this link http://www.gust.org.pl/projects/e-foundry 4) Upstream URL should be http://jmn.pl/en/antykwa-torunska/ 5) good if all %global are written at top of spec 6) I don't think you need to %global shortname to be added as its only used once and not changing value so better remove it. 7) %description text looks very big. Can it be reduced? 8)You need to specify some priority to this config file. You can see the reference for this in /etc/fonts/conf.d/README. you can choose any number from 60 to 69 (In reply to Parag AN(पराग) from comment #1) > Suggestions: > > 1) good if unnecessary information is removed from font wiki page > > 2) generally we create wiki pages with all the words in small letter 1-2: I didn't write the wiki page :) I already removed some stuff from there, what exactly do you have in mind? > 3) why this package name starts with gust? You want to use it as foundry? If > yes good to add some reference like how gust is related to this font. When I > search on google, I found its related in this link > http://www.gust.org.pl/projects/e-foundry Yes, they (GUST="tex users group") have a bunch of fonts, so I intend to add at least "gust-antykwa-pultawskiego-fonts" later on. > 4) Upstream URL should be http://jmn.pl/en/antykwa-torunska/ Fixed. > 5) good if all %global are written at top of spec I moved one. %versiontag I kept, it is better to keep it next to %{version}, which it uses. > 6) I don't think you need to %global shortname to be added as its only used > once and not changing value so better remove it. This specfile should be reusable without almost any changes for some of the other fonts from gust, so this %global is in preparation for that. > 7) %description text looks very big. Can it be reduced? Definitely. Fixed. > 8)You need to specify some priority to this config file. You can see the > reference for this in /etc/fonts/conf.d/README. you can choose any number > from 60 to 69 I used 69. Thank you for the comments. Spec URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska-fonts-2.08-2.fc20.src.rpm ? so sorry for not getting back. Got busy in some other work. will look into new srpm the new srpm is not downloading. Please submit updated srpm again Spec URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska-fonts-2.08-2.fc20.src.rpm Sorry, this version had typos and was missing a %global. Also, the spec file should be called with -fonts (the same as the only binary package that is produces). Hopefully all fixed now. Spec URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska-fonts.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska-fonts-2.08-3.fc20.src.rpm Looking at http://fedoraproject.org/wiki/Fontconfig_packaging_tips page, we need a generic names and Registering a font in default families rules in fontconfig file. another thing remove line 33 in spec that contains #' Created attachment 837578 [details]
fontconfig file
fontconfig file covering rules for each family for the packaged font
Created attachment 837936 [details] document using the font Thank you for the patch. Spec URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska-fonts.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/gust-antykwa-torunska-fonts-2.08-4.fc20.src.rpm I'm also attaching a simple lo document that I used for tests. The font appears to work correctly now. Thanks for attaching the document. Package is good to go in Fedora. APPROVED. New Package SCM Request ======================= Package Name: gust-antykwa-torunska-fonts Short Description: Two-element typeface for typesetting of small prints Owners: zbyszek Branches: f18 f19 f20 InitialCC: Git done (by process-git-requests). No longer creating f18 branches. gust-antykwa-torunska-fonts-2.08-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/gust-antykwa-torunska-fonts-2.08-4.fc20 gust-antykwa-torunska-fonts-2.08-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gust-antykwa-torunska-fonts-2.08-4.fc19 gust-antykwa-torunska-fonts-2.08-4.fc19 has been pushed to the Fedora 19 testing repository. gust-antykwa-torunska-fonts-2.08-4.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: gust-antykwa-torunska-fonts Branches: f19 f20 devel InitialCC: fonts-sig I'd like the Fonts SIG to be notified of changes to this package in all active branches. Complete. |