Bug 1024148

Summary:	Initscript doesn't exit with an error when failing
Product:	[Fedora] Fedora EPEL	Reporter:	Pierre Ynard <linkfanel>
Component:	unbound	Assignee:	Paul Wouters <pwouters>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	el6	CC:	i, linkfanel, pwouters, thozza
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	unbound-1.5.1-2.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-10 15:11:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pierre Ynard 2013-10-29 00:55:14 UTC

Description of problem:

When trying to start unbound with `service unbound start` and it fails for one reason or another (e.g. address already in use), even though the error and FAILED message is clearly printed, the exit status of the initscript is still 0: the error is not reported in the exit status. Among other, this tricks management scripts into wrongly believing that the service was started successfully, etc.

Indeed, there is no provision in the initscript such as `set -e` or `exit $?` to report error codes.

Version-Release number of selected component (if applicable): 1.4.19-1.el6

Comment 1 Christopher Meng 2013-12-14 04:21:03 UTC

Non-fatal POSTIN scriptlet failure in rpm package unbound-libs-1.4.21-1.el6.x86_64
warning: %post(unbound-libs-1.4.21-1.el6.x86_64) scriptlet failed, exit status 1

Comment 2 Fedora Update System 2016-04-21 01:20:09 UTC

unbound-1.5.1-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9fdb5f90e7

Comment 3 Paul Wouters 2016-04-21 19:36:42 UTC

please test?

Comment 4 Fedora Update System 2016-04-22 20:47:31 UTC

unbound-1.5.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9fdb5f90e7

Comment 5 Fedora Update System 2016-05-10 15:11:46 UTC

unbound-1.5.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 6 Pierre Ynard 2016-08-08 21:14:27 UTC

I long stopped administrating these systems, I'll be unable to test.