Bug 1024561

Summary: S01reboot kills itself on nfsroot systems, hanging system
Product: Red Hat Enterprise Linux 6 Reporter: John Westlund <john.westlund>
Component: initscriptsAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED ERRATA QA Contact: Jan Ščotka <jscotka>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.4CC: psklenar
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: initscripts-9.03.41-1.el6 Doc Type: Bug Fix
Doc Text:
When issuing a reboot, or halt the system sometimes kills the S01reboot process and never completes a reboot or shutdown. The culprit that kills S01reboot: fstab-decode /sbin/fuser -m $remaining 2>/dev/null | sed -e "s/\b$$\b//" | xargs kill $sig >/dev/null fstab-decode /sbin/fuser -m $remaining reports back two copies of the scripts PID and the sed command only removes the first. Changing the regex for sed to "s/\b$$\b//g" resolves the issue.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-14 06:27:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John Westlund 2013-10-30 00:10:23 UTC 
Description of problem:
When issuing a reboot, or halt the system kills the S01reboot process and never completes a reboot or shutdown.

Version-Release number of selected component (if applicable):
initscripts-9.03.38-1.el6_4.2.x86_64

How reproducible:
Reboot a nfsroot system, bind mounts for RW parts of the FS may or may not be required to reproduce.

Steps to Reproduce:
1. reboot
2.
3.

Actual results:
system hangs after trying to umount filesystems

Expected results:
system reboots or halts

Additional info:
The issue appears to be in /etc/init.d/functions in the __umount_loop() function.

This line appears to be the culprit that kills S01reboot:
fstab-decode /sbin/fuser -m $remaining 2>/dev/null  | sed -e "s/\b$$\b//" | xargs kill $sig >/dev/null

fstab-decode /sbin/fuser -m $remaining reports back two copies of the scripts PID and the sed command only removes the first. Changing the regex for sed to "s/\b$$\b//g" resolves the issue, but there may be other issues in the function that are resulting in this being a problem.
Comment 2 Lukáš Nykrýn 2013-10-30 07:48:49 UTC 
This check was introduced in 6.4, before that it killed the script even in the case there was one pid. But thnaks for the report and we will fix that.
Comment 3 Lukáš Nykrýn 2014-03-26 12:47:32 UTC 
Patch committed to upstream rhel branch 
https://git.fedorahosted.org/cgit/initscripts.git/commit/?h=rhel6-branch&id=07d6e84e37c915b8e17e5682143daf8c22732600
Comment 6 errata-xmlrpc 2014-10-14 06:27:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1448.html