Bug 1024922

Summary:	[brandbot] getting full crash report after completing the cert update on the guest
Product:	Red Hat Enterprise Linux 7	Reporter:	Rehana <redakkan>
Component:	initscripts	Assignee:	initscripts Maintenance Team <initscripts-maint-list>
Status:	CLOSED CURRENTRELEASE	QA Contact:	qe-baseos-daemons
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	jscotka, jsefler, lnykryn, rvokal, vpavlin
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	initscripts-9.49.7-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-13 13:22:10 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	863175, 909224

Description Rehana 2013-10-30 15:12:57 UTC

Description of problem:
Observed that updating the content to branded_name after cert update is generating full crash report on the system

Version-Release number of selected component (if applicable):
subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 0.8.29-1
subscription-manager: 1.10.4-1.git.8.5875bae.el7
python-rhsm: 1.10.3-1.git.5.70c0cee.el7

How reproducible:
3/3

Steps to Reproduce:
1.Register a guest machine to candlepin server, with a product installed
2.Attach a subscription having "Brand Type" attribute
3.Verify the content on  /var/lib/rhsm/branded_name file
4.Now empty the content of /var/lib/rhsm/branded_name file
5.Do any cert update (ex: installing another cert)

Actual results:
Observed that as soon i do any cert update i was getting the full crash report as a email, however observed that the content on branded_name file was updated

[root@localhost entitlement]# cat /var/lib/rhsm/branded_name 
[root@localhost entitlement]# subscription-manager attach --pool 8ac6a36241e90df90141e90e6eff074a
Successfully attached a subscription for: RAM Limiting Package (2GB stackable)
You have new mail in /var/spool/mail/root
[root@localhost entitlement]# cat /var/lib/rhsm/branded_name 
Awesome OS Instance Server Bits

crash report content :http://pastebin.test.redhat.com/173282

Expected results:
There shouldnt be any crash report

Additional info:
Also when i tried the same scenario  on the physical machine i was unable to reproduce it, i could reproduce the same only on the  guest machine

Comment 2 Václav Pavlín 2013-10-31 06:16:58 UTC

Hi,

I don't think this is initscripts' issue. As you can see from the crash report, /usr/sbin/brandbot exited with segmentation fault, so I would rather looked for the bug there. Do you have any leads that it was caused by initscripts?

Comment 3 Rehana 2013-10-31 06:36:49 UTC

Discussed with Vaclav about the discussion we had with Bill Nottingham.

Missed to mention about the discussion in the bug report

<email thread>

John Sefler (jsefler) said: 
> Need to share this with Bill Nottingham who I believe is developing brandbot. 

File a bug against initscripts, please. (You can CC me.) Probably just crap
code on my end.

Bill


moving back to initscripts component

Comment 4 Lukáš Nykrýn 2013-11-01 12:07:04 UTC

diff --git a/src/brandbot.c b/src/brandbot.c
index c9b21ec..7418a33 100644
--- a/src/brandbot.c
+++ b/src/brandbot.c
@@ -27,7 +27,7 @@ int main(int argc, char **argv) {
     if (!osrelease)
         return 0;
     oldname = svGetValue(osrelease, "PRETTY_NAME");
-    if (!strcmp(oldname, newname))
+    if (oldname && !strcmp(oldname, newname))
         return 0;
     svSetValue(osrelease, "PRETTY_NAME", newname);
     rc += svWriteFile(osrelease, 0644);

Comment 6 Rehana 2013-11-08 08:19:08 UTC

Retested on, 

rpm -qa | grep initscripts-9.49
initscripts-9.49.7-1.el7.x86_64

[root@dhcp71-109 ~]# subscription-manager version
server type: Red Hat Subscription Management
subscription management server: 0.8.31-1
subscription-manager: 1.10.6-1.el7
python-rhsm: 1.10.6-1.el7

Observed that now there is NO crash report on the system during  branded_name file update

Hence moving this bug to verified

Comment 7 Ludek Smid 2014-06-13 13:22:10 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.