Bug 1025226

Summary:	pykickstart test suite not executed in %check
Product:	Red Hat Enterprise Linux 7	Reporter:	Alexander Todorov <atodorov>
Component:	pykickstart	Assignee:	Chris Lumens <clumens>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Release Test Team <release-test-team-automation>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.0	CC:	atodorov
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pykickstart-1.99.43.6-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-13 11:18:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1024724

Description Alexander Todorov 2013-10-31 09:45:23 UTC

Description of problem:

See https://fedoraproject.org/wiki/Packaging:Guidelines#Test_Suites


There appears to be two make targets to test the package: make check and make test
but they are not executed in %check.


Version-Release number of selected component (if applicable):
pykickstart-1.99.43-1.el7.src.rpm

Comment 1 Chris Lumens 2013-10-31 13:56:56 UTC

They are run before the source package is built, as well as upon every commit here locally.  What purpose does yet another layer of running the same thing provide?

Comment 2 Chris Lumens 2013-10-31 14:07:41 UTC

I mean, I certainly can add it.  It's not hard.  I'm just wondering why it needs to get run in another place.

Comment 3 Alexander Todorov 2013-11-01 10:14:30 UTC

Hi Chris,
the purpose is to be able to collect the test results and measure test coverage more precisely. QE has no way of getting that info if devel is running the test suite locally. 

Otherwise it's a good thing you have this running.

Comment 4 Chris Lumens 2013-11-20 19:24:14 UTC

I've added "make test", but "make check" requires pylint and I don't think we want to add that in to the build process.

Comment 6 Ľuboš Kardoš 2014-02-17 16:13:06 UTC

In version pykickstart-1.99.43.8-1.el7.src.rpm  spec file contains:

%check
make test

Moving to verified.

Comment 7 Ludek Smid 2014-06-13 11:18:45 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.