Bug 1025242

Summary: hunt FTBFS if "-Werror=format-security" flag is used
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: huntAssignee: Gwyn Ciesla <gwync>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: bressers, gwync
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-06 15:25:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
hunt FTBFS fix none

Description Dhiru Kholia 2013-10-31 10:05:13 UTC 
Created attachment 817798 [details]
hunt FTBFS fix

hunt-1.5-17.fc20 fails to build if "-Werror=format-security" flag is used.

...
gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -D_REENTRANT   -c -o timer.o timer.c
synchijack.c: In function ‘need_write_positive’:
synchijack.c:245:2: error: format not a string literal and no format arguments [-Werror=format-security]
  sprintf(fin_msg, suggest_sync_msg(0));


I am working on a proposal to enable "-Werror=format-security" for all packages. For more details, please see https://fedorahosted.org/fesco/ticket/1185 URL.

I have attached a trivial patch to fix this problem. Please review and apply.