Bug 1025254

Summary: vorbisgain FTBFS if "-Werror=format-security" flag is used
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: vorbisgainAssignee: Brian Pepple <bdpepple>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: bdpepple, bressers, noa
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-31 14:02:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
vorbisgain FTBFS fix none

Description Dhiru Kholia 2013-10-31 10:26:25 UTC 
Created attachment 817810 [details]
vorbisgain FTBFS fix

vorbisgain-0.36-12.fc20 fails to build if "-Werror=format-security" flag is used.

...
gcc -DHAVE_CONFIG_H -I. -I. -I.     -O2 -fsigned-char -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -c `test -f 'misc.c' || echo './'`misc.c
misc.c: In function ‘file_error’:
misc.c:59:5: error: format not a string literal and no format arguments [-Werror=format-security]
     fprintf(stderr, strerror(err_num));
     ^
...

I am working on a proposal to enable "-Werror=format-security" for all packages. For more details, please see https://fedorahosted.org/fesco/ticket/1185 URL.

I have attached a trivial patch to fix this problem. Please review and apply.
Comment 1 Brian Pepple 2013-10-31 14:02:20 UTC 
Thanks for the patch.

Fixed in vorbisgain-0.36-13.fc21.