Bug 1025367
Summary: | Review Request: python-requests-oauthlib - OAuthlib authentication support for Requests. | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
Component: | Package Review | Assignee: | Pierre-YvesChibon <pingou> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | mario.blaettermann, notting, package-review, pingou |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | pingou:
fedora-review+
gwync: fedora-cvs+ |
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-01-23 02:52:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1025299 | ||
Bug Blocks: | 1025368, 1025601 |
Description
Ralph Bean
2013-10-31 14:43:45 UTC
* Spec is clean * License is clean and is BSD * Builds fine on F-19 x86_64 * Content is clean * Upstream source: c86bcc7f5773dede54ee1eb6f606313296ee1ad9 requests-oauthlib-0.4.0.tar.gz * srpm source: c86bcc7f5773dede54ee1eb6f606313296ee1ad9 python-requests-oauthlib-0.4.0-1.fc19.src/requests-oauthlib-0.4.0.tar.gz * No bundling seen * rpmlint is almost clean python-requests-oauthlib.noarch: E: explicit-lib-dependency python-oauthlib python-requests-oauthlib.noarch: W: summary-ended-with-dot C OAuthlib authentication support for Requests. python-requests-oauthlib.src: W: summary-ended-with-dot C OAuthlib authentication support for Requests. 2 packages and 0 specfiles checked; 1 errors, 2 warnings. You may want to correct this before importing the package Note: there are no python version supported specified, so you might want to test it on python 2.6 before considering if you want an epel6 branch or not. Note2: is the requirements.txt really of interest as a %doc? Otherwise looks good to me! This package is APPROVED Python macros have changed recently: %{__python} > %{__python2} See https://fedoraproject.org/wiki/Packaging:Python#Macros. Even %{python2_sitelib} instead of %{python_sitelib} is available (not for EPEL), although not mentioned in the guidelines. Updated the rpm macros as per Mario's suggestion. Spec URL: http://threebean.org/rpm/python-requests-oauthlib.spec SRPM URL: http://threebean.org/rpm/python-requests-oauthlib-0.4.0-2.fc19.src.rpm New Package SCM Request ======================= Package Name: python-requests-oauthlib Short Description: OAuthlib authentication support for Requests Owners: ralph Branches: f20 f19 f18 InitialCC: Git done (by process-git-requests). python-requests-oauthlib-0.4.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-requests-oauthlib-0.4.0-2.fc20 python-requests-oauthlib-0.4.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-requests-oauthlib-0.4.0-2.fc19 python-requests-oauthlib-0.4.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-requests-oauthlib-0.4.0-2.fc18 python-requests-oauthlib-0.4.0-2.fc20 has been pushed to the Fedora 20 stable repository. python-requests-oauthlib-0.4.0-2.fc19 has been pushed to the Fedora 19 stable repository. python-requests-oauthlib-0.4.0-2.fc18 has been pushed to the Fedora 18 stable repository. Packages are now in the stable repos, so we can close this bug. I'd like to branch this for epel. I am the current Fedora maintainer. Package Change Request ====================== Package Name: python-requests-oauthlib New Branches: el6 epel7 Owners: ralph Modifying the request to add puiterwijk as an owner Package Change Request ====================== Package Name: python-requests-oauthlib New Branches: el6 epel7 Owners: ralph puiterwijk Git done (by process-git-requests). |