Bug 1025466

See:   https://issues.jboss.org/browse/TEIIDRHQ-18

Completed the changes to teiid-rhq plugin, for renaming data services to data virtualization.

Assigning to David to handle the product renaming in the build.

Hi Van/Filip,
  Can one of you clarify this request as soon as possible? Thx.
----- Original Message -----
> From: "Simeon Pinder" <spinder>
> To: "Van Halbert" <vhalbert>
> Cc: "Filip Nguyen" <fnguyen>, "Leonard Dimaggio" <ldimaggi>, "David Stahl" <dstahl>
> Sent: Friday, November 1, 2013 5:07:52 PM
> Subject: Re: DV Plugin Pack rebuild request
> 
> Hi Van and Filip,
> 
>   So there's a little confusion here. A few things to clarify before I can
>   act on this:
> 
> i)The 'plugin pack' represents the most up to date management functionality
> for your product, which typically includes multiple 'plugins' and versions.
> Ex. EDS plugin pack includes all related EDS plugins() and the associated
> dependencies.  Additionally one can have one's plugin pack name changed
> without changing any of the underlying plugins(eds-p*,teid*,soa-p*) or
> versions. See following for ER4 plugin pack
> name(http://download.devel.redhat.com/brewroot/packages/org.jboss.on-jboss-on-parent/3.2.0.ER4/2/maven/org/jboss/on/jon-plugin-pack-dataservices/3.2.0.ER4/jon-plugin-pack-dataservices-3.2.0.ER4.zip),
> and look into the same for the plugin pack contents and all of it's
> associated management dependencies.
> 
> ii)Any change to the plugin pack, name or payload requires a plugin pack
> request.  Multiple changes can be included in a single request/BZ.
> 
> iii)All plugin pack update requests typically follow the process described
> here: https://docspace.corp.redhat.com/docs/DOC-124228
> 
> With that being said, it looks like you want:
> 1)plugin pack rename from 'DATASERVICES' -> DV.  Is this correct? Title from
> [1] implies as much. This is the least clear of all your current requests.
> 2)You'd like the EDS/Dataservice plugin pack depdendency for teeid-rhq-plugin
> version updated to '1.0.0.Final-redhat-4' from
> '1.0.0.Final-redhat-2'(current version requested by [2]).
> https://bugzilla.redhat.com/show_bug.cgi?id=1025466#c3 implies that this
> should now be the latest.
> 3)[1] should be assigned to me as the JON team is still responsible for the
> formalized plugin pack builds.  Assuming you want that BZ to track the
> plugin pack change request.
> 
> Since you've already created [1], it is fine to make the modifications if the
> above is correct. Please advise if I have interpreted the requested changes
> correctly.
> 
> -Simeon
> 
> ----- Original Message -----
> > From: "Van Halbert" <vhalbert>
> > To: "Filip Nguyen" <fnguyen>
> > Cc: "Simeon Pinder" <spinder>, "Leonard Dimaggio"
> > <ldimaggi>, "David Stahl" <dstahl>
> > Sent: Friday, November 1, 2013 10:08:00 AM
> > Subject: Re: DV Plugin Pack rebuild request
> > 
> > Including David on this.  I believe he pulled the new code and was kicking
> > off a build (IIRC).
> > 
> > Van
> > 
> > ----- Original Message -----
> > From: "Filip Nguyen" <fnguyen>
> > To: "Simeon Pinder" <spinder>
> > Cc: "Van Halbert" <vhalbert>, "Leonard Dimaggio"
> > <ldimaggi>
> > Sent: Friday, November 1, 2013 8:47:13 AM
> > Subject: DV Plugin Pack rebuild request
> > 
> > Hi Simeon,
> > I wanted to ask about the process of rebuilding the plugin pack for DV
> > 6. Since Van finished the changes [1] in our plugin pack (reflecting
> > product name change) should we request the rebuild again or is this [2]
> > sufficient?
> > 
> > [1] https://bugzilla.redhat.com/show_bug.cgi?id=1025466
> > <https://bugzilla.redhat.com/show_bug.cgi?id=1025466>
> > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1010365
> > <https://bugzilla.redhat.com/show_bug.cgi?id=1010365>

We need to propagate a change of the product (former Data Services) to Data Virtualization, that would mean:

* plugin pack name change ("jon-plugin-pack-dataservices-" -> "jon-plugin-pack-datavirtualization-")

* plugins name changes ("eds-p-" -> "dv-")

Code changes for ModeShape and Teiid plugins has been pushed to  jboss-integration git repo. So these changes also need to be propagated integrated.

I have made the requested changes which are available to test in the latest brew build: https://brewweb.devel.redhat.com//buildinfo?buildID=306513 (JON 3.2.0.ER5)

More specifically:
- the plugin pack was renamed from dataservices -> datavirtualization
- teeid-rhq-plugin version updated to '1.0.0.Final-redhat-4' from '1.0.0.Final-redhat-2'
- no eds-p plugin name changes were made at this time since the specific "eds-p" plugin pack dependencies were all for existing/legacy plugins (eds-p-5.3.0.GA-*plugin.jar) and there were no other specific dependency changes mentioned in any of the associated BZ's.

@Filip and @Van, please have your team test/verify and report any issues with these changes.  I will consider this request complete unless indicated otherwise.

Van Halbert <vhalbert> made a comment on jira TEIIDRHQ-18

1 issue, the modeshape-rhq plugin isn't in the zip.      Not sure who should be pulling the jboss-integration/modeshape-rhq into the build.

@Van, thanks for catching that. Can you get me or have someone:
i) get me the brew library links for the 'modeshape-rhq plugin'
ii)confirm that that plugin[i] needs to be added as a dependency for the datavirtualization plugin pack for JON 3.2.0.GA? 

I'll get started on pulling those changes in for JON 3.2.0.ER6 which I'm going to start working on as early as tomorrow. 

Thx.

Van Halbert <vhalbert> made a comment on jira TEIIDRHQ-18

Modeshape rhq plugin should be included the same way the Teiid rhq plugin is included.

This is fixed with commit ada950dabad5e6e to jon.git. Moving this to MODIFIED for testing with next brew build.

ER6 was found to be a bad build, but ER7 is valid and includes this fix as well. 

@Van and @Dave, this is available for verification.

Cancelling original needinfo.

Assuming we don't need to document this as an issue in Release Notes - setting to requires_doc_text- accordingly.