Bug 1025485

Summary: Git push reports deployments to the broker twice
Product: OpenShift Online Reporter: Andy Goldstein <agoldste>
Component: ImageAssignee: Ben Parees <bparees>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 2.xCC: bparees, chunchen, dmcphers, pmorie
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-26 19:08:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Andy Goldstein 2013-10-31 19:23:34 UTC 
Description of problem: When pushing changes to an application, the deployments are reported to the broker twice


Version-Release number of selected component (if applicable):


How reproducible: 100%


Steps to Reproduce:
1. Create app
2. Make a change
3. Git push

Actual results:

Broker log will show DeploymentsController#create called twice

Expected results:

Broker log will show DeploymentsController#create called just once


Additional info:

We report deployments in post_receive and in activate_local_gear, and post_receive ultimately invokes activate_local_gear. It's probably sufficient just to report deployments in activate_local_gear and remove the call from post_receive.
Comment 1 Ben Parees 2014-01-22 14:35:41 UTC 
https://github.com/openshift/origin-server/pull/4542
Comment 2 openshift-github-bot 2014-01-22 21:21:35 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/274a0067bb6008a49e6fff9e4d2f3c10e8ce7e48
Bug 1025485 - Git push reports deployments to the broker twice
Comment 3 chunchen 2014-01-23 11:16:55 UTC 
It's fixed, verified on devenv_4263, please refer to the following results:

1. Create app
2. Make a change
3. Git push

# tail -f development.log | grep -i DeploymentsController

2014-01-23 06:14:47.138 [INFO ] Processing by DeploymentsController#create as JSON (pid:2673)