Bug 1025718 (CVE-2013-4488)

Summary: CVE-2013-4488 libgadu: missing ssl certificate validation
Product: [Other] Security Response Reporter: Ratul Gupta <ratulg>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: debarshir, dominik, itamar, jrusnack
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-10 17:25:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1025719, 1026505    
Bug Blocks: 1025720    

Description Ratul Gupta 2013-11-01 11:21:50 UTC 
Libgadu, an open library for communicating using the protocol e-mail, was found to have missing the ssl certificate validation. The issue is that libgadu uses openSSL library for creating secure connections. A program using openSSL can perform SSL handshake by invoking the SSL_connect function. Some cetrificate validation errors are signaled through, the return values of the SSL_connect, while for the others errors SSL_connect returns OK but sets internal "verify result" flags. Application must call ssl_get_verify_result function to check if any such errors occurred.  This check seems to be missing in libgadu. And thus a man-in-the-middle attack is possible failing all the SSL protection.

Upstream suggested that it was a concious decision as libgadu is reverse-engineered implementation of a proprietary protocol, they had no control over the certificates used for SSL connections, so they would add a note to the documentation about this.

References:
http://seclists.org/oss-sec/2013/q4/202
https://bugzilla.novell.com/show_bug.cgi?id=848509
http://www.mail-archive.com/libgadu-devel@lists.ziew.org/msg01017.html
Comment 1 Ratul Gupta 2013-11-01 11:22:46 UTC 
Created libgadu tracking bugs for this issue:

Affects: fedora-all [bug 1025719]
Comment 3 Vincent Danen 2013-11-04 20:10:08 UTC 
Looks like these are relevant upstream commits:

https://github.com/wojtekka/libgadu/commit/035e3cf6227995bdbe95f663a938a3838131e022
https://github.com/wojtekka/libgadu/commit/04bde7415ff0d87267a2dfd78aa3ba8da6434389
https://github.com/wojtekka/libgadu/commit/77fdc9351bf5c1913c7fc518f8a0c0c87ab3860f
https://github.com/wojtekka/libgadu/commit/23644f1fb8219031b3cac93289a588b05f90226b
https://github.com/wojtekka/libgadu/commit/d882b15661ee94949919ebbbc43edf0db5f619cb
https://github.com/wojtekka/libgadu/commit/6516e57766b4fa39d1c5b37379ea72a330598a13

Hard to say if there are more as the changelog is not in english.
Comment 4 Fedora Update System 2013-12-28 02:02:55 UTC 
libgadu-1.12.0-0.2.rc1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 5 Fedora Update System 2013-12-28 02:03:40 UTC 
libgadu-1.12.0-0.2.rc1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 7 Dominik 'Rathann' Mierzejewski 2015-02-10 08:57:57 UTC 
Can this be closed?