Bug 1025773

Summary:	disk stays in "image locked" status long after action (snapshot preview) failure when all related task are gone from vdsm and engine
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	David Jaša <djasa>
Component:	ovirt-engine	Assignee:	Gilad Chaplik <gchaplik>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Lukas Svaty <lsvaty>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.3.0	CC:	acathrow, amureini, dfediuck, gchaplik, iheim, lpeer, mavital, Rhev-m-bugs, sgotliv, srevivo, yeylon, yzaslavs
Target Milestone:	---	Keywords:	Triaged
Target Release:	3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	sla
Fixed In Version:	is25	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	SLA	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1038284

Description David Jaša 2013-11-01 14:13:50 UTC

Description of problem:
I did a Preview snapshot of a VM and the action failed. The disk in question remained in "Image locked" state not just after the job/task was declared failed, but even after it was deleted from vdsm jobs and also from engine jobs.
It also took quite a long time before the jobs were deleted from vdsm and engine (but they eventually were purged so this is good).

The disk status should be changed to Active right after the job is no longer active instead.

Version-Release number of selected component (if applicable):
is19-is20.1

How reproducible:
the task failure that triggered the bug occurred just once

Steps to Reproduce:
1. make some async task on disk fail
2.
3.

Actual results:
the disk remains in "image locked" state forever

Expected results:
the disk status is cleared right after the job terminates in any way

Additional info:

Comment 1 David Jaša 2013-11-01 14:18:31 UTC

Created attachment 818297 [details]
engine logs

Comment 3 David Jaša 2013-11-01 14:32:23 UTC

just to be clear on jobs: bot "vdsClient -s 0 getAllTasks{Statuses,Info}" and GET /api/jobs show empty result...

Comment 7 Lukas Svaty 2013-11-15 13:31:47 UTC

can u provide steps how to reproduce/verify this?

Comment 8 Gilad Chaplik 2013-11-17 15:19:42 UTC

I'd like to select a different approach for solving this bug.
moving it back to assigned.
I will provide steps once the bug gets back to you 

Thanks

Comment 9 David Jaša 2013-11-25 12:40:12 UTC

Is the fix supposed to release the "image locked" status of a disk that already got to the state or is it supposed just to prevent reaching such a condition?

Comment 10 Gilad Chaplik 2013-11-25 14:20:14 UTC

(In reply to David Jaša from comment #9)
> Is the fix supposed to release the "image locked" status of a disk that
> already got to the state or is it supposed just to prevent reaching such a
> condition?

preventing.

(In reply to Lukas Svaty from comment #7)
> can u provide steps how to reproduce/verify this?

Add a quota to a disk, and create a snapshot.
move the DC to disabled quota mode, and remove the quota.
now try to preview the snapshot.

Comment 11 Lukas Svaty 2013-11-27 13:21:00 UTC

tested on is25

Comment 12 Itamar Heim 2014-01-21 22:30:55 UTC

Closing - RHEV 3.3 Released

Comment 13 Itamar Heim 2014-01-21 22:30:55 UTC

Closing - RHEV 3.3 Released

Comment 14 Itamar Heim 2014-01-21 22:33:52 UTC

Closing - RHEV 3.3 Released