Bug 1025829

Summary: sysprep floppy is not attached to Windows 2008 R2 machine - even when specifically checked in Run Once
Product: Red Hat Enterprise Virtualization Manager Reporter: David Jaša <djasa>
Component: ovirt-engineAssignee: Roy Golan <rgolan>
Status: CLOSED CURRENTRELEASE QA Contact: Ilanit Stein <istein>
Severity: high Docs Contact:
Priority: urgent    
Version: 3.3.0CC: acathrow, djasa, eedri, iheim, lpeer, mavital, michal.skrivanek, mpoledni, ofrenkel, Rhev-m-bugs, sbonazzo, vfeenstr, yeylon
Target Milestone: ---Keywords: Regression
Target Release: 3.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: is27 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1027349, 1049022    

Description David Jaša 2013-11-01 17:09:16 UTC 
Description of problem:
sysprep floppy is not attached to Windows 2008 R2 machine - even when specifically checked in Run Once

Version-Release number of selected component (if applicable):
is20.2:
rhevm-backend-3.3.0-0.30.beta1.el6ev.noarch

How reproducible:
always

Steps to Reproduce:
1. create vm with windows 2008 R2 os type, "Run Once" it with [sysprep] floppy checked
2. check if VM has floppy attached
3.

Actual results:
floppy is not attached to VM at all (vdsm doesn't get floppy in the device list of createVm command so unsuprisingly libvirt XML contains just hard & cdrom disks)

Expected results:
floppy is generated & attached

Additional info:
my VMs are created from template
Comment 2 David Jaša 2013-11-01 18:13:46 UTC 
Note: when I change the OS type of the very same VM to e.g. Windows 7 x64, the floppy is attached just fine...
Comment 5 Michal Skrivanek 2013-11-12 12:40:41 UTC 
trivial typo in packaging/setup/plugins/ovirt-engine-setup/config/options.py for W2k8r2 sysprep file location
Comment 6 Sandro Bonazzola 2013-11-14 13:55:47 UTC 
merged upstream on master and 3.3 branch
Comment 7 Ilanit Stein 2013-11-21 15:06:00 UTC 
Is this fix included in is24.1?

Checked on is24.1: Failed QA:

1. Create a new VM, select Windows 2008 R2 x64 OS, runOnce with floppy:[sysprep]
On vdsm.log, VM device list didn't contain the floppy.

2. Create a new VM, select Windows XP OS, runOnce with floppy:[sysprep]

On vdsm.log, this VM device list contained the floppy:

               <disk device="floppy" snapshot="no" type="file">
                        <source file="/var/run/vdsm/payload/fa126bd8-8e33-42b1-8c4f-62419b05be9c.c12189a70f6714c9c761e15fc52bb56f.img" startupPolicy="optional"/>
                        <target bus="fdc" dev="fda"/>
                        <readonly/>
                        <serial/>
                        <readonly/>
                </disk>
Comment 9 Ilanit Stein 2013-11-24 06:42:57 UTC 
Bug moved to assigned since it failed QA (comment #7).
Comment 10 Michal Skrivanek 2013-12-04 09:20:08 UTC 
did you run engine-setup with a clean DB? 
do you see /etc/ovirt-engine/sysprep/sysprep.2k8 file on the engine host?
can you check the VdcOptions value of SysPrep2K8R2Path for a typo?
Comment 11 David Jaša 2013-12-04 14:36:42 UTC 
(In reply to Michal Skrivanek from comment #10)
> did you run engine-setup with a clean DB? 

the engine was installed at around is19 time, it's updated ever since.

> do you see /etc/ovirt-engine/sysprep/sysprep.2k8 file on the engine host?

yes

> can you check the VdcOptions value of SysPrep2K8R2Path for a typo?

# engine-config -a | grep SysPrep2K8R2Path
SysPrep2K8R2Path: /etc/ovirt-engine/gs4ysprep/sysprep.2k8 version: general

But even after I fixed it and restarted the engine, my 2008 R2 VMs just don't get their sysprep floppies....
Comment 12 Michal Skrivanek 2013-12-06 11:41:14 UTC 
Roy, it should be sysprep.2k8x64, the files are deployed as sysprep.2k8x86. And the comment should be fixed for R2 in osinfo file as well

The VdcOptions are not used anymore, so the whole section in patch 21261 should be removed. The file needs to be renamed directly in source tree packaging/etc/sysprep/
Comment 14 Vinzenz Feenstra [evilissimo] 2013-12-11 15:26:10 UTC 
Merged to ovirt-engine/master as http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=0b40aeb2e5832609ae5c07557c72fd978cdd673c

Merged to ovirt-engine/ovirt-engine-3.3 as http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=cd2efe559d7f7de74c19a0549669d25b25a1aabd

Merged to ovirt-engine/ovirt-engine-3.3.2 as http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=fe74046800283ef656f3b3b39d890c669c91aca3
Comment 15 Ilanit Stein 2013-12-16 09:13:41 UTC 
Verified on is27:

Create a new VM, select Windows 2008 R2 x64 OS, runOnce with floppy:[sysprep]
On vdsm.log, VM device list contain the floppy:

<disk device="floppy" snapshot="no" type="file">
			<source file="/var/run/vdsm/payload/72345e72-9d85-48e4-b202-e15c7e0061d5.d6c90b7ad310136c04125524e1b69216.img" startupPolicy="optional"/>
			<target bus="fdc" dev="fda"/>
			<readonly/>
			<serial/>
			<readonly/>
		</disk>
Comment 16 Itamar Heim 2014-01-21 22:27:13 UTC 
Closing - RHEV 3.3 Released
Comment 17 Itamar Heim 2014-01-21 22:27:39 UTC 
Closing - RHEV 3.3 Released
Comment 18 Itamar Heim 2014-01-21 22:30:24 UTC 
Closing - RHEV 3.3 Released