Bug 1026095 (doclifter)
| Summary: | Review Request: doclifter - Translates documents written in troff macros to DocBook | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mario Blättermann <mario.blaettermann> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting, package-review, rc040203 |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | doclifter-2.13-2.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-10 06:52:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mario Blättermann
2013-11-03 15:53:08 UTC
Love esr's tools. Taken. Requires
--------
doclifter (rpmlib, GLIBC filtered):
/usr/bin/env
/usr/bin/python
Well, I think you should patch env path to %{__python2}.
Others are fine.
Once fixed I will approve.
OK, I've changed the shebangs to python2, in case of doclifter even without /usr/bin/env. New files: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/doclifter.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/doclifter-2.13-2.fc19.src.rpm PACKAGE APPROVED. Many thanks for the review! New Package SCM Request ======================= Package Name: doclifter Short Description: Translates documents written in troff macros to DocBook Owners: mariobl Branches: f19 f20 Does this package also work with python3? To me, it doesn't make much sense to introduce new python2 packages into Fedora at this point in time. Git done (by process-git-requests). (In reply to Ralf Corsepius from comment #6) > Does this package also work with python3? > > To me, it doesn't make much sense to introduce new python2 packages into > Fedora at this point in time. Well, it would be fine to let it depend on Python3, although Python2 hasn't reached EOL yet in Fedora. Currently it doesn't work. The package build fails on the tests: + make check capabilities File "../doclifter", line 469 return "<Frame: " + `self.__dict__` + ">" ^ SyntaxError: invalid syntax *** Nonzero return status on capabilities! make[1]: *** [regress] Error 1 make: *** [check] Error 2 Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.uON8zA (%check) When I disable them, the package builds, but doclifter fails with a syntax error: $ doclifter knapsen.1 File "/bin/doclifter", line 469 return "<Frame: " + `self.__dict__` + ">" ^ SyntaxError: invalid syntax That's why I will import the Python2 package for the time being, but I will ask the upstream developer Eric S. Raymond for a solution. Maybe it is simply to fix with 2to3, but my knowledge is poor in this case, so it is up to Eric to fix it. Thanks in any case for the hint. You are right, if we have the chance to use Python3, we should do so. I will have a look at my Python2 based packages if they run with Python3. As far as I can remember, sfbm should be able to. doclifter-2.13-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/doclifter-2.13-2.fc19 doclifter-2.13-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/doclifter-2.13-2.fc20 doclifter-2.13-2.fc19 has been pushed to the Fedora 19 testing repository. OT: It's not easy to approach Eric, I packaged 3 softwares of him from Apr, and he still hasn't replied to any of emails sent by myself... doclifter-2.13-2.fc20 has been pushed to the Fedora 20 stable repository. doclifter-2.13-2.fc19 has been pushed to the Fedora 19 stable repository. |