Bug 102629
Summary: | multiload applet graph gets cleared on autohide panels | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nils Philippsen <nphilipp> | ||||
Component: | gnome-applets | Assignee: | Mark McLoughlin <markmc> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Mike McLean <mikem> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 1 | CC: | bart.martens | ||||
Target Milestone: | --- | Keywords: | MoveUpstream, Triaged | ||||
Target Release: | --- | ||||||
Hardware: | i386 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-02-21 18:58:08 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Nils Philippsen
2003-08-19 05:40:18 UTC
Changed product to Fedora Core. Looking at it again, the graph gets displayed properly for the fraction of a second and only gets cleared after that. Created attachment 97652 [details]
gnome-applets-2.4.1-realloc.patch
When the multiload applet configure callback is called, don't clear the data if
the width hasn't changed.
Note that when unhiding, the applet flashes. That is due to another bug, probably in gnome-panel. Use the workaround mentioned of bug #102632 to avoid the flashing. I'm not seeing the clear on unhide problem with gnome-applet-2.4.1-1 in an updated FC1. Is anyone still having the problem or should this be closed? I still see the problem on gnome-panel-2.4.0-3, gnome-applets-2.4.1-1. The workaround in #102632 doesn't help me (neither with the panel flickering nor with the multiload applet's redraw issue). This bug has been submitted upstream by Bart Martens to: http://bugzilla.gnome.org/show_bug.cgi?id=134337 After re-reading bug #102632, I noticed that it's instructions called additionally for clearing the expand property of the panel. When I did so with this bug, it manifested. It could, in my case, be prevented by changing the panel background to another colour or an image (the workaround mentioned above). triage->upstream Comment on attachment 97652 [details]
gnome-applets-2.4.1-realloc.patch
Marking the patch as obsolete.
I marked the patch of comment #2 as obsolete, for two reasons. First, the patch solves the problem only for a horizontal panel, not for a vertical one (thank you Dennis Smit). Second, I see now that the workaround of comment #3 is not only suppresses the flashing, but makes the whole bug disappear, for both a horizontal panel and a vertical one. This is definitely not true here. See my latest comment (3) on bug #102632. gnome-applets-2.4.1-1 gnome-panel-2.4.0-3 gnome-applets-2.4.1/multiload/load-graph.c gnome-panel-2.4.0/gnome-panel/panel-toplevel.c I found some more information with gdb. When auto-unhiding, function load_graph_configure is called or not depending on whether the gnome-panel background is none or color. How does that come? Well, there is some logic in function panel_toplevel_update_edges that causes resizing depending on whether the gnome-panel background is none (PANEL_BACK_NONE) or something else. Disabling the lines from 1370 until 1394 makes the problem disappear, exactly like setting the gnome-panel background to color. But disabling these lines has side effects: no "bevels", so that's not the solution. The solution is probably to do the "bevels"-stuff earlier, so not at auto-unhiding time, to avoid the unneccessary resizing. So this may be a gnome-panel bug instead of a gnome-applets bug. Maybe the solution will also fix the problem of bug #102632. I need some help on this. Anyone? (Nils, are you sure you tested what Joseph Mocker wrote, that is, setting the gnome-panel background to color? Three persons say that it does make the problem disappear. I can't explain why this didn't have the positive effect during your test. Could you check this again please?) Upstream info updated. http://bugzilla.gnome.org/show_bug.cgi?id=134337 *** This bug has been marked as a duplicate of 102632 *** Changed to 'CLOSED' state since 'RESOLVED' has been deprecated. |