Bug 1026595

Summary:	remove the <"locked": false> from QMP monitor for passthrough disk (scsi-block )
Product:	Red Hat Enterprise Linux 7	Reporter:	Sibiao Luo <sluo>
Component:	qemu-kvm	Assignee:	Virtualization Maintenance <virt-maint>
Status:	CLOSED CANTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.0	CC:	acathrow, bsarathy, chayang, juzhang, michen, mkenneth, pbonzini, qzhang, virt-maint, xfu
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1026591	Environment:
Last Closed:	2013-11-05 10:23:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1026591
Bug Blocks:

Comment 1 Sibiao Luo 2013-11-05 03:13:29 UTC

host info:
# uname -r && rpm -q qemu-kvm
3.10.0-33.el7.x86_64
qemu-kvm-1.5.3-10.el7.x86_64

# /usr/libexec/qemu-kvm -M pc -enable-kvm -m 2048 -smp 2,sockets=2,cores=1,threads=1 -drive file=/dev/sr0,if=none,id=drive-cdrom-disk,format=raw,media=cdrom,werror=stop,rerror=stop,readonly=on -device virtio-scsi-pci,bus=pci.0,addr=0x8,id=scsi0 -device scsi-block,drive=drive-cdrom-disk,bus=scsi0.0,id=cdrom-disk,bus=scsi0.0 -vnc :1 -monitor stdio -qmp tcp:0:4444,server,nowait
QEMU 1.5.3 monitor - type 'help' for more information
(qemu) info block
drive-cdrom-disk: removable=0 io-status=ok file=/dev/sr0 ro=1 drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0
...
{"execute":"query-block"}
{"return": [{"io-status": "ok", "device": "drive-cdrom-disk", "locked": false, "removable": false, "inserted": {"iops_rd": 0, "iops_wr": 0, "ro": true, "backing_file_depth": 0, "drv": "raw", "iops": 0, "bps_wr": 0, "encrypted": false, "bps": 0, "bps_rd": 0, "file": "/dev/sr0", "encryption_key_missing": false}, "type": "unknown"}...]}

Best regards,
sluo

Comment 2 Paolo Bonzini 2013-11-05 10:23:23 UTC

For historical reasons, the "locked" field in the output of "query-block" is mandatory.  It will even be present in hard disks, for example (unlike tray-open).  So it cannot be removed.