Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Description of problem:
This patch should be backported:
commit 702d66a813dd84afd7c3d1ad8cbdcc8e3449bcd9
Author: Michael S. Tsirkin <mst>
Date: Tue Sep 17 11:45:36 2013 +0300
virtio-net: fix up HMP NIC info string on reset
When mac is updated on reset, info string has stale data.
Fix it up.
Signed-off-by: Michael S. Tsirkin <mst>
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index dd41008..22dbd05 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -314,6 +314,7 @@ static void virtio_net_reset(VirtIODevice *vdev)
n->mac_table.uni_overflow = 0;
memset(n->mac_table.macs, 0, MAC_TABLE_ENTRIES * ETH_ALEN);
memcpy(&n->mac[0], &n->nic->conf->macaddr, sizeof(n->mac));
+ qemu_format_nic_info_str(qemu_get_queue(n->nic), n->mac);
memset(n->vlans, 0, MAX_VLAN >> 3);
}
How reproducible:
100%
Steps to Reproduce:
1. boot guest with virtio nic
2. change mac address in guest by
ifconfig eth0 hw ether 12:12:12:01:01:01:01
3. reboot guest
4. checking macaddr info in monitor repeatedly
# info network
Actual results:
the macaddr of virtio nic in monitor isn't reset
Expected results:
the mac info is updated during the reset
Comment 1Miroslav Rezanina
2013-11-07 15:56:08 UTC
Reproduce this bug as follow version:
Host:
# uname -r
3.10.0-52.el7.x86_64
# rpm -q qemu-kvm
qemu-kvm-1.5.3-16.el7.x86_64
Guest :3.10.0-48.el7.x86_64
Steps:
1. Boot guest with virtio nic
...-netdev tap,id=hostnet0,vhost=on,script=/etc/qemu-ifup -device virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:60:3f:29,bus=pci.0,addr=0x4 ...
2. Change mac address in guest by
#ifconfig eth0 hw ether 12:12:12:01:01:09
3. Reboot guest
4. checking macaddr info in monitor repeatedly
# info network
Results: the macaddr of virtio nic in monitor isn't reset
(qemu) info network
net0: index=0,type=nic,model=virtio-net-pci,macaddr=12:12:12:01:01:09
\ hostnet0: index=0,type=tap,ifname=tap0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
Verify this bug as follow version:
Host:
# uname -r
3.10.0-52.el7.x86_64
# rpm -q qemu-kvm
qemu-kvm-1.5.3-19.el7.x86_64
Guest:3.10.0-48.el7.x86_64
Steps as same as reproduce
Results:
After step4,macaddr change to original one
(qemu) info network
net0: index=0,type=nic,model=virtio-net-pci,macaddr=52:54:00:60:3f:29
\ hostnet0: index=0,type=tap,ifname=tap0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
Addtional info :Tried about 3 times ,not hit any problem
According to above test ,this bug has fixed.
This request was resolved in Red Hat Enterprise Linux 7.0.
Contact your manager or support representative in case you have further questions about the request.
Description of problem: This patch should be backported: commit 702d66a813dd84afd7c3d1ad8cbdcc8e3449bcd9 Author: Michael S. Tsirkin <mst> Date: Tue Sep 17 11:45:36 2013 +0300 virtio-net: fix up HMP NIC info string on reset When mac is updated on reset, info string has stale data. Fix it up. Signed-off-by: Michael S. Tsirkin <mst> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index dd41008..22dbd05 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -314,6 +314,7 @@ static void virtio_net_reset(VirtIODevice *vdev) n->mac_table.uni_overflow = 0; memset(n->mac_table.macs, 0, MAC_TABLE_ENTRIES * ETH_ALEN); memcpy(&n->mac[0], &n->nic->conf->macaddr, sizeof(n->mac)); + qemu_format_nic_info_str(qemu_get_queue(n->nic), n->mac); memset(n->vlans, 0, MAX_VLAN >> 3); } How reproducible: 100% Steps to Reproduce: 1. boot guest with virtio nic 2. change mac address in guest by ifconfig eth0 hw ether 12:12:12:01:01:01:01 3. reboot guest 4. checking macaddr info in monitor repeatedly # info network Actual results: the macaddr of virtio nic in monitor isn't reset Expected results: the mac info is updated during the reset