Bug 1027046

Summary: [ALL_LANG] Unlocalized tab labels in Create/Update Subnet windows
Product: Red Hat OpenStack Reporter: Yuko Katabami <ykatabam>
Component: python-django-horizonAssignee: Julie Pichon <jpichon>
Status: CLOSED ERRATA QA Contact: Lijun Li <lijli>
Severity: unspecified Docs Contact:
Priority: low    
Version: 4.0CC: aortega, athomas, jpichon, mrunge, qe-i18n-bugs, yeylon
Target Milestone: z1Keywords: i18n, Triaged, ZStream
Target Release: 4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-django-horizon-2013.2.1-1.el6ost Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-23 14:24:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Create Subnet - unlocalized tab label
none
Update Subnet - unlocalized tab labels
none
Subnet tab label in Create Subnet window -- fixed
none
Subnet tab label in Update Subnet window -- fixed none

Description Yuko Katabami 2013-11-06 01:05:18 UTC
Created attachment 820098 [details]
Create Subnet - unlocalized tab label

Description of problem:
Tab labels in Create/Update Subnet windows are unlocalized

Version-Release number of selected component (if applicable): 4.0


How reproducible: 100%


Steps to Reproduce:
1. Log in to Dashboard with Admin account.
2. Click "Settings" menu and select a language other than English.
3. On the left side panel, select Admin => Netwokrs
4. On the main panel, click a network name to open Network Detail page.
5. Click "Create Subnet" button to open "Create Subnet" window and check the tabs and close it.
6. Also click "Edit Subnet" action button for a subnet to open "Update Subnet" window and check the tabs.

Actual results:
In "Create Subnet" window, tab label "Subnet" is unlocalized.
In "Update Subnet" window, tab labels "Subnet" and "Subnet Details" is unlocalized.

Expected results:
Screenshots attached.


Additional info:

Comment 1 Yuko Katabami 2013-11-06 01:05:59 UTC
Created attachment 820099 [details]
Update Subnet - unlocalized tab labels

Comment 3 Yuko Katabami 2013-11-06 01:43:21 UTC
Corresnponding strings in upstream file (for_use_horizon_openstack-dashboard-translations_ja.po):

#: dashboards/admin/networks/subnets/tables.py:32
#: dashboards/project/loadbalancers/tables.py:194
#: dashboards/project/loadbalancers/workflows.py:36
#: dashboards/project/networks/workflows.py:116
#: dashboards/project/networks/subnets/tables.py:45
#: dashboards/project/networks/templates/networks/subnets/_detail_overview.html:7
#: dashboards/project/routers/ports/forms.py:32
#: dashboards/project/vpn/tables.py:126 dashboards/project/vpn/workflows.py:35
msgid "Subnet"
msgstr "サブネット"

#: dashboards/project/networks/workflows.py:192
#: dashboards/project/networks/templates/networks/subnets/detail.html:3
#: dashboards/project/networks/templates/networks/subnets/detail.html:6
msgid "Subnet Detail"
msgstr "サブネットの詳細"

Comment 4 Julie Pichon 2013-11-12 16:45:31 UTC
As Yuko indicates the translated strings are available. They are not showing due to programming errors: the strings are not properly marked as translatable in the code, e.g. https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/networks/subnets/workflows.py#n121 , leading underscore missing.

Comment 5 Julie Pichon 2013-11-27 10:47:40 UTC
Backported upstream for 2013.2.1.

Comment 7 Yuko Katabami 2014-01-21 05:38:38 UTC
Created attachment 852960 [details]
Subnet tab label in Create Subnet window -- fixed

Comment 8 Yuko Katabami 2014-01-21 05:39:11 UTC
Created attachment 852962 [details]
Subnet tab label in Update Subnet window -- fixed

Comment 9 Yuko Katabami 2014-01-21 05:39:44 UTC
Verified on the latest RHOS 4.0.z puddle. Screenshot attached. Moving the status to VERIFIED.

Comment 12 Lon Hohberger 2014-02-04 17:20:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2014-0046.html