Bug 1027123

Created attachment 820247 [details]
patch to include symbols necessary for chromium

Description of problem:
The re2 library doesn't export the _ZNK3re211FilteredRE210AllMatches* symbols which are used by Spot's chromium packages:

http://repos.fedorapeople.org/repos/spot/chromium-stable/

Version-Release number of selected component (if applicable):
re2-20130115-3.fc20.x86_64

How reproducible:
Reproducible.

Steps to Reproduce:
1. Install chromium from Spot's repo (currently no F-20 version available, but the F-19 build will suffice).
2. Run it.

Actual results:
nils@gibraltar:~> chromium-browser
/usr/lib64/chromium-browser/chromium-browser: symbol lookup error: /usr/lib64/chromium-browser/chromium-browser: undefined symbol: _ZNK3re211FilteredRE210AllMatchesERKNS_11StringPieceERKSt6vectorIiSaIiEEPS6_

Expected results:
Runs.

Additional info:
Spot's repo contains a patched version of the re2 package exporting this symbol (patch attached). Additionally, it adds "-pthread" to the CXXFLAGS (instead of just to LDFLAGS) and runs only the shared library tests (omitting tests on the static and debugging versions of the library). Here's the diff in the spec file:

diff --git a/re2.spec b/re2.spec
index 6a99621..6dc4649 100644
--- a/re2.spec
+++ b/re2.spec
@@ -8,6 +8,8 @@ Group:          System Environment/Libraries
 License:        BSD
 URL:            http://code.google.com/p/%{name}/
 Source0:        http://re2.googlecode.com/files/%{name}-%{version}.tgz
+# Chromium needs the FilteredRE2 symbols to be global
+Patch0:                re2-global-FilteredRE2-symbols.patch
 BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 
 %description
@@ -36,13 +38,14 @@ you will need to install %{name}-devel.
 
 %prep
 %setup -q -n %{name}
+%patch0 -p1 -b .global-fix
 
 %build
 # The -pthread flag issue has been submitted upstream:
 # http://groups.google.com/forum/?fromgroups=#!topic/re2-dev/bkUDtO5l6Lo
 # The RPM macro for the linker flags does not exist on EPEL
 %{!?__global_ldflags: %global __global_ldflags -Wl,-z,relro}
-CXXFLAGS="${CXXFLAGS:-%optflags}"
+CXXFLAGS="${CXXFLAGS:-%optflags} -pthread"
 LDFLAGS="${LDFLAGS:-%__global_ldflags} -pthread"
 make %{?_smp_mflags} CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" includedir=%{_includedir} libdir=%{_libdir}
 
@@ -54,7 +57,7 @@ make install INSTALL="install -p" DESTDIR=$RPM_BUILD_ROOT includedir=%{_included
 find $RPM_BUILD_ROOT -name 'lib%{name}.a' -exec rm -f {} \;
 
 %check
-make %{?_smp_mflags} test
+make %{?_smp_mflags} shared-test
 
 %clean
 rm -rf $RPM_BUILD_ROOT
@@ -73,8 +76,8 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %changelog
-* Sun Aug 04 2013 Fedora Release Engineering <rel-eng.org> - 20130115-3
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
+* Sun Jun  2 2013 Tom Callaway <spot> - 20130115-3
+- fix FilteredRE2 symbols to be global in the shared library
 
 * Sun Feb 17 2013 Denis Arnaud <denis.arnaud_fedora> 20130115-2
 - Took into account the feedback from review request (#868578).