Bug 1027210

Summary: remove the use of health servlet (hosted-engine)
Product: [oVirt] ovirt-hosted-engine-setup Reporter: Sandro Bonazzola <sbonazzo>
Component: GeneralAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED WONTFIX QA Contact: Leonid Natapov <lnatapov>
Severity: low Docs Contact:
Priority: medium    
Version: ---CC: bugs, didi, juan.hernandez, lveyde, nbarcet, rbalakri, Rhev-m-bugs, sbonazzo, srevivo, stirabos, talayan, ylavi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1026723 Environment:
Last Closed: 2018-06-18 07:13:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1009843, 1138598    
Bug Blocks:    

Description Sandro Bonazzola 2013-11-06 11:22:07 UTC
+++ This bug was initially created as a clone of Bug #1026723 +++

The health servlet is a legacy interface that IMO should not be used at all,
marked obsolete and removed as soon as we can.

Please make the notification service use the formal supported API to pull
engine status.

This applies to both setup and hosted.

Thanks!

--- Additional comment from Sandro Bonazzola on 2013-11-06 04:24:11 EST ---

(In reply to Alon Bar-Lev from comment #0)
> Please make the notification service use the formal supported API to pull
> engine status.

 import ovirtsdk.api
 ovirtapi=ovirtsdk.api.API(
   url='https://sbonazzo.csb/api',
   username='admin@internal',
   password='****',
   ca_file='/etc/pki/ovirt-engine/ca.pem',
 )
 once connection is established (engine running), how may I know if DB is Up?

--- Additional comment from Alon Bar-Lev on 2013-11-06 04:35:27 EST ---

our application is not initialized if database connection is down... or do you suggest otherwise...?

# systemctl stop ovirt-engine
# systemctl stop postgresql
# systemctl start ovirt-engine
# curl -v -k https://admin%40internal:engine@localhost/api
# systemctl start postgresql
# curl -v -k https://admin%40internal:engine@localhost/api

BTW: I do not see our application recovering from database down anyway...

Comment 1 Alon Bar-Lev 2013-11-06 11:23:42 UTC
Why have you closed? this is for 3.4... just commit it upstream it will be visible in downstream.

Comment 2 Sandro Bonazzola 2013-11-06 11:35:37 UTC
I've just cloned to ovirt-hosted-engine-setup component since the original bug pointed to both engine-setup and hosted-engine setup.

Comment 3 Sandro Bonazzola 2014-08-12 08:39:28 UTC
Postponed to 3.6.0 due to authentication issues after SDK changes requiring ssl connection.
Probably the best approach is to have a not authenticated API just to check the status of the system instead of authenticating with the SDK but I don't know when we can have it.

Comment 4 Sandro Bonazzola 2016-09-01 07:38:47 UTC
Juan, will we keep health servlet in 4.1? If yes, I'm for postponing this to 4.2.

Comment 5 Juan Hernández 2016-09-01 07:52:51 UTC
I don't have any good reason to keep or remove that servlet. Do we know what is using it?

Comment 6 Sandro Bonazzola 2016-09-22 10:53:38 UTC
I'm aware only of ovirt-live and ovirt-hosted-engine-setup.

Comment 7 Juan Hernández 2016-09-22 12:50:34 UTC
If those components use that service and we support them, then I'd say that we can't remove this servlet.