Bug 1027841

Summary:	The same key can be used multiple time when adding property in "New resource" wizard
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Jakub Cechacek <jcechace>
Component:	Web Console - UX	Assignee:	Heiko Braun <hbraun>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Jelinek <pjelinek>
Severity:	high	Docs Contact:	eap-docs <eap-docs>
Priority:	low
Version:	6.2.0	CC:	cdewolf, crobson, hbraun, hpehl, jawilson, jdoyle, jkudrnac, rhatlapa, rpelisse
Target Milestone:	CR1	Keywords:	Reopened
Target Release:	EAP 6.4.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Usability
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-07-09 11:38:18 UTC	Type:	Task
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1219165, 1222380

Description Jakub Cechacek 2013-11-07 13:00:51 UTC

There is no uniqueness check when adding properties in "New resource" wizard. Thus it is possible to use the same key multiple times and consequently the creation process will fail with an error. User will also lose all entered data. 

An example of such behavior is declaration of properties when creating new XA Datasource


How to reproduce:
1) navigate to XA datasources page
2) start creating new XA Datasource
3) In property declaration step create multiple properties with the same key
4) finish the wizard 

expected result: user is not allow to use the same key multiple times in property declaration step 
actual result: creation process is finish with error

Comment 1 Heiko Braun 2014-07-09 11:38:18 UTC

In agreement with Catherine we've decided that UX issues will be tracked separately.

Comment 2 Jakub Cechacek 2014-07-21 10:00:19 UTC

Issue moved under the UX component. 

Also moved to 6.4 as this issue is still valid for 6.3. Use ack flags to decide whether we want to go through with it or not.

Comment 3 Catherine Robson 2014-08-01 17:16:40 UTC

This sounds like we just need to do validation on the property declaration step to ensure that the key names are unique.  I'm not sure there is anything UX needs to design around this fix.  Assigning back to Heiko as expecting no UX design needed.

Comment 4 Heiko Braun 2014-08-25 13:34:37 UTC

Agreed w. Catherine: we just check for double entries

Comment 6 Romain Pelisse 2015-04-24 12:20:33 UTC

As I've looked at some other issues on the webconsole, I'm going to give a stab at this one.

@Heiko, let me know if you have already a fix underway

Comment 7 Harald Pehl 2015-04-28 08:18:28 UTC

No one is currently working on that issue. So would be great if you take a stab at this one.

Comment 8 Romain Pelisse 2015-04-30 11:41:41 UTC

Here is the PR for upstream: https://github.com/hal/core/pull/31

And the PR for the maintenance branch (2.5.x): https://github.com/hal/core/pull/30

Comment 9 Harald Pehl 2015-05-16 09:43:44 UTC

Marged into upstream, 2.6.x and 2.5.x

Comment 12 Pavel Jelinek 2015-06-19 11:22:40 UTC

Verified for Create XA Datasource wizard of EAP 6.4.2.CP.CR1

Comment 13 JBoss JIRA Server 2016-05-30 22:43:56 UTC

Claudio Miranda <claudio.br> updated the status of jira HAL-305 to Resolved

Comment 14 Petr Penicka 2017-01-17 10:19:14 UTC

Retroactively bulk-closing issues from released EAP 6.4 cumulative patches.

Comment 15 Petr Penicka 2017-01-17 10:19:15 UTC

Retroactively bulk-closing issues from released EAP 6.4 cumulative patches.