Bug 1028381

Summary:	[ovirt-guest-agent] `service ovirt-guest-agent start` prints 'Starting ovirt-guest-agent:' even the agent is already started
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Jiri Belka <jbelka>
Component:	ovirt-guest-agent	Assignee:	Vinzenz Feenstra [evilissimo] <vfeenstr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jiri Belka <jbelka>
Severity:	low	Docs Contact:
Priority:	low
Version:	3.3.0	CC:	iheim, michal.skrivanek, mkenneth, rbalakri, yeylon
Target Milestone:	---
Target Release:	3.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:	vt2.1	Doc Type:	Bug Fix
Doc Text:	Previously, when starting the rhevm-guest-agent service when it was already running, reported that it was started. When it actually did not do anything. This can be confusing to users in some cases. This issues has been now resolved and it no longer reports as being started, but is reporting nothing as if the start of the service would have not done anything.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-02-17 08:28:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1142923, 1156165

Description Jiri Belka 2013-11-08 10:34:28 UTC

Description of problem:
Nitpicking... But consistency.

# service sshd status
openssh-daemon (pid  1813) is running...
# service sshd status ; echo $?
openssh-daemon (pid  1813) is running...
0
# service sshd start ; echo $?
0
# service ovirt-guest-agent status ; echo $?
ovirt-guest-agent (pid  28458) is running...
0
# service ovirt-guest-agent start ; echo $?
Starting ovirt-guest-agent: 
0

Version-Release number of selected component (if applicable):
is21

How reproducible:
100%

Steps to Reproduce:
1. have ovirt-guest-agent running
2. service ovirt-guest-agent start
3.

Actual results:
confusing output - Starting ovirt-guest-agent:

Expected results:
no output

Additional info:
it confused me, i forgot if GA is running so i tried to start it and this output confused me because there is no '[OK]'. so was it started with my command or what...?

Comment 1 Jiri Belka 2013-11-08 10:40:37 UTC

Same on RHEL6 and RHEL5. Although RC scripts on RHEL are mess, still most of them do not print output in this context (blame auditd, cgconfig...).

Comment 2 Vinzenz Feenstra [evilissimo] 2014-06-05 08:12:00 UTC

Merged u/s as http://gerrit.ovirt.org/gitweb?p=ovirt-guest-agent.git;a=commit;h=6666b1d9c82ba6fdaa27bc4300d1d223bf487063

Comment 3 Jiri Belka 2014-09-04 12:22:35 UTC

ok,

- el6:

[root@jb-onqa ~]# service ovirt-guest-agent start ; echo $?
Starting ovirt-guest-agent:                                [  OK  ]
0
[root@jb-onqa ~]# service ovirt-guest-agent status ; echo $?
ovirt-guest-agent (pid  28753) is running...
0
[root@jb-onqa ~]# service ovirt-guest-agent start ; echo $?
0

- el5:

[root@localhost ~]# service ovirt-guest-agent start ; echo $?
Starting ovirt-guest-agent:                                [  OK  ]
0
[root@localhost ~]# service ovirt-guest-agent status ; echo $?
ovirt-guest-agent (pid  2470) is running...
0
[root@localhost ~]# service ovirt-guest-agent start ; echo $?
0

Comment 4 Omer Frenkel 2015-02-17 08:28:27 UTC

RHEV-M 3.5.0 has been released