Bug 1028436

Summary: Unnecessary dependency in wicket-war quickstart pom.xml
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Nikoleta Hlavickova <nziakova>
Component: QuickstartsAssignee: sgilda
Status: CLOSED CURRENTRELEASE QA Contact: Nikoleta Hlavickova <nziakova>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bsutter, jkudrnac, ozizka, pmuir
Target Milestone: CR1   
Target Release: EAP 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-15 16:20:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nikoleta Hlavickova 2013-11-08 12:55:02 UTC
Description of problem:
wicket-war quickstart can be built and deployed without org.apache.wicket:wicket-core

Version-Release number of selected component (if applicable):
EAP 6.2.0 ER7

How reproducible:
always

Steps to Reproduce:
1. open jboss-eap-6.2.0.GA-quickstarts/wicket-war/pom.xml

2. remove this BOM from dependencyManagement:

            <!-- Wicket -->
            <dependency>
                <groupId>org.apache.wicket</groupId>
                <artifactId>wicket-core</artifactId>
                <version>${version.org.apache.wicket}</version>
            </dependency>

3. remove this dependency from dependencies:

        <!-- Wicket -->
        <dependency>
            <groupId>org.apache.wicket</groupId>
            <artifactId>wicket-core</artifactId>
        </dependency>

4. remove this dependency version from properties:

   <version.org.apache.wicket>6.9.1</version.org.apache.wicket>

5. follow README for this QS and deploy the application

Actual results:
Application can be built and deployed.

Expected results:
No unnecessary dependency in QS pom.xml

Comment 1 Nikoleta Hlavickova 2013-11-08 13:29:15 UTC
The same with wicket-ear quickstart.

Comment 2 sgilda 2013-11-08 16:53:33 UTC
@ozizka: Can you confirm it's OK to remove that from the pom file?

Comment 3 sgilda 2013-11-08 17:56:29 UTC
Removed wicket-core from wicket-war and wicket-ear POM files in this pull:
https://github.com/jboss-developer/jboss-eap-quickstarts/pull/728

Comment 4 Ondřej Žižka 2013-11-08 18:01:43 UTC
I'd have to look, but if Nikoleta tried it and it works without, there's no reason to keep it. Good catch, Niki.

Originally the QS was a bit more complex but I removed most of it; that's where the deps came from.

Comment 6 Nikoleta Hlavickova 2013-11-15 07:46:12 UTC
Verified for EAP 6.2.0 CR1.