Bug 1028710

Summary:	gcc arguments used on the build system result in errors that cannot be disabled.
Product:	Red Hat Enterprise Linux 6	Reporter:	Brian Lane <bcl>
Component:	redhat-rpm-config	Assignee:	Panu Matilainen <pmatilai>
Status:	CLOSED NOTABUG	QA Contact:	BaseOS QE Security Team <qe-baseos-security>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	6.4	CC:	dennis, djw8605, mastahnke, rdieter
Target Milestone:	pre-dev-freeze
Target Release:	6.6
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-16 12:02:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1028609

Description Brian Lane 2013-11-09 20:33:59 UTC

Description of problem:
On the el6 branch gcc is being called with options that result in warnings that cannot be disabled being treated as errors.

eg. http://kojipkgs.fedoraproject.org//work/tasks/8032/6158032/build.log

-Wno-unused-result was apparently added in gcc 4.5 so it cannot be used to disable the warning/error.

This must have changed since the last build of bip since the line in question has been in the source tree since 2005.

Comment 1 Rex Dieter 2013-11-10 00:34:45 UTC

Better to just not build with -Werror (which is arguably silly for release builds)

Comment 2 Dennis Gilmore 2013-11-10 04:13:36 UTC

moving to redhat-rpm-config and rhel, which is where it is all defined.

Comment 4 Panu Matilainen 2014-01-16 12:02:23 UTC

-Werror can be useful for development work but its a terrible idea to use it for "release builds" because of issues like this: compilers can and do grow new warnings over time so code which at some point compiled free of any warnings might trip tonnes of warnings with a later compiler version.

NOTABUG, just eliminate the -Werror usage.