Bug 1028757

Summary: [RHEVM][vNIC profiles] No possibility to set custom device propertied for versions < 3.3
Product: Red Hat Enterprise Virtualization Manager Reporter: Mike Kolesnik <mkolesni>
Component: ovirt-engineAssignee: Mooli Tayer <mtayer>
Status: CLOSED WONTFIX QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: acathrow, bazulay, emesika, iheim, lpeer, Rhev-m-bugs, yeylon
Target Milestone: ---   
Target Release: 3.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-21 17:43:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mike Kolesnik 2013-11-10 13:47:14 UTC
Description of problem:
vNIC profile will implicitly use the version of the DC to determine which custom device properties to display, however the DC level is not relevant and instead only the cluster level (which is determined by the VM using the profile).

When trying to set custom properties config key:
$ ~/devenv/ovirt-engine//bin/engine-config -s CustomDeviceProperties="{type=interface;prop={myProp=[a-zA-Z0-9-]+}}" --cver=3.2
Cannot set value {type=interface;prop={myProp=[a-zA-Z0-9-]+}} to key CustomDeviceProperties. Device custom properties are not supported in version 3.2



Version-Release number of selected component (if applicable):


How reproducible:
Always


Steps to Reproduce:
1. Create a < 3.3 DC
2. Edit the management network profile
3.

Actual results:
The dialog always shows "No available keys"


Expected results:
It should be possible to set custom properties and use them in the profile


Additional info:
First of all the tying of DC version to the profile is, like in bug 1024209, unnecessary and limiting without good cause.

Secondly, I think device custom properties config value split by versions is just complicating the feature and I don't think it is a necessary complication, hence I suggest to consolidate the values into one and drop the version checks on the config value itself, that is not the way to do it anyway.
The version check should be on VM level (either when using the custom properties there, or running the VM).

Comment 1 Mike Kolesnik 2013-11-11 10:32:24 UTC
Moving to infra since vNIC profiles can't use cluster versions because it's in the DC tree, so the only available version is the DC version..