Bug 1028985

Summary:	~/.openshift/oo-install-cfg.yml should be overwritten.
Product:	OpenShift Container Platform	Reporter:	Johnny Liu <jialiu>
Component:	Containers	Assignee:	Luke Meyer <lmeyer>
Status:	CLOSED NOTABUG	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	medium
Version:	2.0.0	CC:	hripps, jialiu, libra-onpremise-devel, lmeyer
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-20 09:45:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Johnny Liu 2013-11-11 12:23:12 UTC

Description of problem:
Run oo-install every time, only change is saved into ~/.openshift/oo-install-cfg.yml, some useless info is still saved in the file, it is a little confused to user, suggest to re-write this file after run oo-install every time.

Version-Release number of selected component (if applicable):
oo-install-ose-2.0b-20131108-2228

How reproducible:
Always

Steps to Reproduce:
1. Following https://access.redhat.com/site/articles/492873 to do the following operation.
$ curl http://oo-install.rhcloud.com/ose-2.0b/ -o oo-install
$ chmod +x ./oo-install
$ ./oo-install -e -a
2. Finish installation using rhsm, and ~/.openshift/oo-install-cfg.yml is generated, here the following info is saved into the file.
Subscription:
  type: rhsm
  rh_username: qa1
  rh_password: xxxx
3. Run oo-install again, the time I selected "none" method.

Actual results:
"none" method is saved into the file, but other info sill are there.
Subscription:
  type: none
  rh_username: qa1
  rh_password: xxxx

This is not a critical issue, and currently does NOT affect it functionality, but if a new file is generated to overwrite the old one, that would be perfect, and not confuse user.


Expected results:
After run oo-install every time, the default config file should be re-write, no previous setting info is seen in the file.

Additional info:

Comment 2 Luke Meyer 2013-11-19 14:17:34 UTC

oo-install does rewrite the config file each time; but it does not clear out irrelevant settings as you point out. We could consider this a feature or a bug; I find it kind of convenient to keep the subscription settings around. but it is a little surprising.

Comment 3 N. Harrison Ripps 2013-11-19 15:52:20 UTC

I intentionally left in the unused config settings. This way, when a user changes subscription info, relevant settings are picked up and offered as default values to the user. As you point out, it does not negatively impact the user experience or the installer function.

Johnny, if you are comfortable with this response, please close out the bug as NOTABUG. Otherwise, please let us know why the information should be purged from the config file so that we can discuss it.

Comment 4 Johnny Liu 2013-11-20 09:45:21 UTC

I am OK for that.