Bug 1029053

Summary: [abrt] NetworkManager-0.9.9.0-15.git20131003.fc20: update_permanent_hw_address: Process /usr/sbin/NetworkManager was killed by signal 11 (SIGSEGV)
Product: [Fedora] Fedora Reporter: Dan Horák <dan>
Component: NetworkManagerAssignee: Dan Williams <dcbw>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: dcbw
Target Milestone: ---Flags: mleitner: needinfo-
Target Release: ---   
Hardware: s390x   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/81186d4d7f7200bfdffa9cebce54a92201afb8d9
Whiteboard: abrt_hash:987e4fbac3ff4301acb91684a6461f9b4cd18eb8
Fixed In Version: NetworkManager-0.9.9.0-19.git20131003.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1029430 (view as bug list) Environment:
Last Closed: 2013-11-26 03:58:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765, 1029430    
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: environ
none
File: exploitable
none
File: limits
none
File: maps
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages none

Description Dan Horák 2013-11-11 14:44:29 UTC 
Description of problem:
crash happens when config file for CTC adapter on s390x is present

Version-Release number of selected component:
NetworkManager-0.9.9.0-15.git20131003.fc20

Additional info:
reporter:       libreport-2.1.9
backtrace_rating: 4
cmdline:        /usr/sbin/NetworkManager --no-daemon
crash_function: update_permanent_hw_address
executable:     /usr/sbin/NetworkManager
kernel:         3.11.7-300.fc20.s390x
runlevel:       N 3
type:           CCpp
uid:            0

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 update_permanent_hw_address
 #1 constructed
 #2 g_object_new_with_custom_constructor at gobject.c:1721
 #3 g_object_new_internal at gobject.c:1744
 #4 g_object_new_valist at gobject.c:2002
 #6 nm_device_ethernet_new
 #7 platform_link_added_cb
 #8 ffi_call_SYSV at ../src/s390/sysv.S:275
 #9 ffi_call at ../src/s390/ffi.c:525
 #10 g_cclosure_marshal_generic at gclosure.c:1454
Comment 1 Dan Horák 2013-11-11 14:44:36 UTC 
Created attachment 822433 [details]
File: backtrace
Comment 2 Dan Horák 2013-11-11 14:44:40 UTC 
Created attachment 822434 [details]
File: cgroup
Comment 3 Dan Horák 2013-11-11 14:44:43 UTC 
Created attachment 822435 [details]
File: core_backtrace
Comment 4 Dan Horák 2013-11-11 14:44:46 UTC 
Created attachment 822436 [details]
File: dso_list
Comment 5 Dan Horák 2013-11-11 14:44:50 UTC 
Created attachment 822437 [details]
File: environ
Comment 6 Dan Horák 2013-11-11 14:44:53 UTC 
Created attachment 822438 [details]
File: exploitable
Comment 7 Dan Horák 2013-11-11 14:44:57 UTC 
Created attachment 822439 [details]
File: limits
Comment 8 Dan Horák 2013-11-11 14:45:00 UTC 
Created attachment 822440 [details]
File: maps
Comment 9 Dan Horák 2013-11-11 14:45:03 UTC 
Created attachment 822441 [details]
File: open_fds
Comment 10 Dan Horák 2013-11-11 14:45:07 UTC 
Created attachment 822442 [details]
File: proc_pid_status
Comment 11 Dan Horák 2013-11-11 14:45:10 UTC 
Created attachment 822443 [details]
File: var_log_messages
Comment 12 Dan Williams 2013-11-11 21:44:38 UTC 
I think the problem is that our ethernet code doesn't correctly handle devices that have no MAC address, and CTC devices don't have one because they aren't ethernet.  But we treat them as ethernet in NM for convenience.

Should be fixed upstream as:

696f655d7c7b605d0344aeb6ba4ff643cd46a5b4
ethernet: don't crash if device doesn't have a MAC address (rh #1029053)
Comment 13 Dan Horák 2013-11-15 10:08:46 UTC 
I can confirm the fix from comment #12 fixes the issue, no crash with CTC adapter configured. Can we expect an updated build soon?
Comment 14 Fedora Update System 2013-11-20 14:31:57 UTC 
NetworkManager-0.9.9.0-19.git20131003.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/NetworkManager-0.9.9.0-19.git20131003.fc20
Comment 15 Fedora Update System 2013-11-24 03:41:47 UTC 
Package NetworkManager-0.9.9.0-19.git20131003.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing NetworkManager-0.9.9.0-19.git20131003.fc20'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-21973/NetworkManager-0.9.9.0-19.git20131003.fc20
then log in and leave karma (feedback).
Comment 16 Fedora Update System 2013-11-26 03:58:34 UTC 
NetworkManager-0.9.9.0-19.git20131003.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.