Bug 1029186

Summary: libteamdctl should not link against libdaemon
Product: Red Hat Enterprise Linux 7 Reporter: Dan Williams <dcbw>
Component: libteamAssignee: Jiri Pirko <jpirko>
Status: CLOSED CURRENTRELEASE QA Contact: Jan Tluka <jtluka>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: jpirko, rkhan
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libteam-1.9-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 12:46:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
don't link with libdaemon none

Description Dan Williams 2013-11-11 21:08:01 UTC
libteamdctl doesn't need libdaemon for anything.  Possibly C&P error, I think.

diff -up libteam-1.8/libteamdctl/Makefile.am.foo libteam-1.8/libteamdctl/Makefile.am
--- libteam-1.8/libteamdctl/Makefile.am.foo	2013-11-11 15:03:47.548099036 -0600
+++ libteam-1.8/libteamdctl/Makefile.am	2013-11-11 15:03:50.750059006 -0600
@@ -8,7 +8,7 @@ AM_LDFLAGS = -Wl,--gc-sections -Wl,--as-
 lib_LTLIBRARIES = libteamdctl.la
 libteamdctl_la_SOURCES = libteamdctl.c cli_usock.c cli_dbus.c cli_zmq.c
 libteamdctl_la_CFLAGS= $(AM_CFLAGS) $(JANSSON_CFLAGS) $(DBUS_CFLAGS) -I${top_srcdir}/include -D_GNU_SOURCE
-libteamdctl_la_LIBADD= $(JANSSON_LIBS) $(DBUS_LIBS) $(ZMQ_LIBS) $(LIBDAEMON_LIBS)
+libteamdctl_la_LIBADD= $(JANSSON_LIBS) $(DBUS_LIBS) $(ZMQ_LIBS)
 libteamdctl_la_LDFLAGS = $(AM_LDFLAGS) -version-info @LIBTEAMDCTL_CURRENT@:@LIBTEAMDCTL_REVISION@:@LIBTEAMDCTL_AGE@
 
 pkgconfigdir = $(libdir)/pkgconfig

Comment 1 Dan Williams 2013-11-11 21:08:54 UTC
Bugzilla wrapping makes it look odd, attaching patch too.

Comment 2 Dan Williams 2013-11-11 21:09:27 UTC
Created attachment 822628 [details]
don't link with libdaemon

Comment 4 Jiri Pirko 2013-11-12 17:32:56 UTC
fixed by upstream commit:

commit ebf4147d3076b8f1c5b399474f06b5ec38688776
Author: Jiri Pirko <jiri>
Date:   Tue Nov 12 18:30:28 2013 +0100

    libteamdctl: remove false lib dependencies

Comment 6 Jan Tluka 2013-11-27 13:19:06 UTC
# rpm -q teamd
teamd-1.8-1.el7.x86_64
# ldd /usr/lib64/libteamdctl.so
	linux-vdso.so.1 =>  (0x00007fffd45fe000)
	libjansson.so.4 => /lib64/libjansson.so.4 (0x00007f53952e7000)
	libdbus-1.so.3 => /lib64/libdbus-1.so.3 (0x00007f53950a1000)
	libdaemon.so.0 => /lib64/libdaemon.so.0 (0x00007f5394e99000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f5394ad8000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f53948bc000)
	librt.so.1 => /lib64/librt.so.1 (0x00007f53946b3000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f5395700000)

# rpm -q teamd
teamd-1.9-1.el7.x86_64
# ldd /usr/lib64/libteamdctl.so.0
	linux-vdso.so.1 =>  (0x00007fff2dbfe000)
	libdbus-1.so.3 => /lib64/libdbus-1.so.3 (0x00007fdf0d307000)
	libc.so.6 => /lib64/libc.so.6 (0x00007fdf0cf46000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fdf0cd29000)
	librt.so.1 => /lib64/librt.so.1 (0x00007fdf0cb21000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fdf0d75b000)

Setting to VERIFIED.

Comment 7 Ludek Smid 2014-06-13 12:46:05 UTC
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.