| Summary: | Review Request: dcw-gmt - Digital Chart of the World (DCW) for GMT | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting, package-review |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-12 15:55:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1029197 | ||
|
Description
Orion Poplawski
2013-11-11 21:31:02 UTC
URL ?= http://www.soest.hawaii.edu/wessel/dcw/ Source0 ?= http://www.soest.hawaii.edu/pwessel/dcw/dcw-gmt-1.1.0.tar.gz --------- ${RPM_BUILD_ROOT}/%{_datadir}: Eithor: $RPM_BUILD_ROOT/%{_datadir} Or: %{buildroot}%{_datadir} That's what you get for re-using existing specs... * Mon Nov 11 2013 Orion Poplawski <orion.com> 1.1.0-2 - Fix URL and Source0 - Use buildroot macro Spec URL: http://www.cora.nwra.com/~orion/fedora/dcw-gmt.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/dcw-gmt-1.1.0-2.fc19.src.rpm Well, one more question about this package. It looks like that it's used by GMT, a software which is being commonly used in geographic area. From the description of this package: " To read and process the data you should install GMT, the Generic Mapping Tools." First I think we don't need this line, second, if I understand correctly, this package should have dependency of GMT otherwise it will be useless. Right? ------------ dcw-gmt.src: W: no-%build-section Please add a note ;) Package is simple and fine, so please answer questions above and I will grant the fedora-review. (In reply to Christopher Meng from comment #3) > Well, one more question about this package. > > It looks like that it's used by GMT, a software which is being commonly used > in geographic area. From the description of this package: > > " To read and process the data you > should install GMT, the Generic Mapping Tools." > > First I think we don't need this line, second, if I understand correctly, > this package should have dependency of GMT otherwise it will be useless. > Right? > I went back and forth on this. I think though if someone really wants to just install this data and use it in some other way they should be able to. GMT however obviously depends on this and requires it. > dcw-gmt.src: W: no-%build-section > > Please add a note ;) Um, okay, done. PACKAGE APPROVED. Thanks for the review. New Package SCM Request ======================= Package Name: dcw-gmt Short Description: Digital Chart of the World (DCW) for GMT Owners: orion Branches: f20 InitialCC: Git done (by process-git-requests). Checked in and built. |