Bug 1029685

Summary: Facter :cart_list fails silently, fact should be removed
Product: OpenShift Online Reporter: Jhon Honce <jhonce>
Component: ContainersAssignee: Jhon Honce <jhonce>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: bmeng, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-30 00:50:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jhon Honce 2013-11-12 22:25:15 UTC
Description of problem:
Facter :cart_list fails silently and returns no values

Version-Release number of selected component (if applicable):


How reproducible:
Always, the supporting command oo-cartridge-list was deleted.

Steps to Reproduce:
1.
2.
3.

Actual results:
fact is empty

Expected results:
fact no longer supported

Additional info:

Comment 1 openshift-github-bot 2013-11-13 00:20:37 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/4e94c47a381f3cfd168e9add0383414202aa96e5
Bug 1029685 - Remove :cart_list fact

* Has been broken for last 3 months, no one complained.

Comment 2 Qiushui Zhang 2013-11-14 02:58:44 UTC
Tested on devenv_4030.

The code is merged in.

But no error is given when doing "facter cart_list" or any other non-existed content. It just fails silently.

[root@ip-10-118-161-73 ~]# facter sshfp
ip-10-118-161-73 IN SSHFP 1 1 0531449c7719704890d44d256b4227b8432e4b0a
[root@ip-10-118-161-73 ~]# facter cart_list
[root@ip-10-118-161-73 ~]# facter test_facter_error


I have tried on old stage instance, e.g. devenv-stage_486, devenv-stage_528.
The behaviour is totally the same.

Mark the bug as "ASSIGNED" to make sure current status is OK (or not).

Comment 3 Jhon Honce 2013-11-14 15:44:04 UTC
facter reports unknown keys as nulls. To ensure cart_list is not being provided use grep. E.g.,

$ facter |grep sshfp
(output from grep)

vs

$ facter |grep cart_list
(nothing)

Comment 4 Meng Bo 2013-11-15 02:01:28 UTC
[root@ip-10-185-56-240 ~]# facter |grep cart_list
[root@ip-10-185-56-240 ~]# 

Checked again on devenv_4038 according comment#3, there is nothing returned when grep the cart_list.

Move bug to verified.