Bug 1029812

Summary: vdsm-tool configure outputs misleading error messages although it ends successfully
Product: Red Hat Enterprise Virtualization Manager Reporter: Vered Volansky <vered>
Component: vdsmAssignee: Yaniv Bronhaim <ybronhei>
Status: CLOSED ERRATA QA Contact: Petr Beňas <pbenas>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.3.0CC: aberezin, acathrow, adahms, amureini, bazulay, iheim, lpeer, mgoldboi, pstehlik, sbonazzo, ybronhei, yeylon
Target Milestone: ---   
Target Release: 3.4.0   
Hardware: Unspecified   
OS: Linux   
Whiteboard: infra
Fixed In Version: ovirt-3.4.0-beta2 Doc Type: Bug Fix
Doc Text:
This update enhances the output produced by the vdsm-tool to provide more information to users on encountering errors.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-09 13:26:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1078909, 1142926    

Description Vered Volansky 2013-11-13 09:41:48 UTC
Description of problem:
When running vdsm-tool configure we get the output as follows:
--------------------------------------------------------------
SUCCESS: ssl configured to true. No conflicts
libvirt is not configured for vdsm yet
sanlock service is already configured
service-status: ServiceOperationError: _serviceStatus failed
Super VDSM daemon is not running

service-status: ServiceOperationError: _serviceStatus failed
VDS daemon is not running

service-status: ServiceOperationError: _serviceStatus failed
libvirtd is stopped

Reconfiguration of libvirt is done

Version-Release number of selected component (if applicable):
--------------------------------------------------------------

How reproducible:


Steps to Reproduce:
1.service libvirtd stop
2.service supervdsmd stop
3.vdsm-tool configure

Actual results:
The above output, as well as successful libvirt configuration.

Expected results:
The service-status: ServiceOperationError: _serviceStatus failed messages give the impression something went wrong, although the configuration was successful.
Assuming the process is fine, they should either be swallowed or marked as notes. Another solution if thought of will also be acceptable.

Additional info:
Ran on a rhel machine.

Comment 1 Yaniv Bronhaim 2013-11-13 11:44:35 UTC
Yes, it looks kinda funny imo. I'll think what we can do there..
Thanks.

Comment 2 Petr Beňas 2014-02-19 11:39:58 UTC
Verified in vdsm-4.14.1-3.el6.x86_64.

[root@slot-7 ~]# vdsm-tool configure

Checking configuration status...

SUCCESS: ssl configured to true. No conflicts
libvirt is not configured for vdsm yet
sanlock service is already configured
Traceback (most recent call last):
  File "/usr/bin/vdsm-tool", line 145, in <module>
    sys.exit(main())
  File "/usr/bin/vdsm-tool", line 142, in main
    return tool_command[cmd]["command"](*args[1:])
  File "/usr/lib64/python2.6/site-packages/vdsm/tool/configurator.py", line 213, in configure
    "--force flag.\n" % s
RuntimeError: 

Cannot configure while service 'vdsmd' is running.
 Stop the service manually or use the --force flag.

[root@slot-7 ~]# service vdsmd stop
Shutting down vdsm daemon: 
vdsm watchdog stop                                         [  OK  ]
vdsm: Running run_final_hooks                              [  OK  ]
vdsm stop                                                  [  OK  ]
[root@slot-7 ~]# vdsm-tool configure

Checking configuration status...

SUCCESS: ssl configured to true. No conflicts
libvirt is not configured for vdsm yet
sanlock service is already configured

Running configure...
Reconfiguration of libvirt is done.

Done configuring modules to VDSM.
[root@slot-7 ~]# vdsm-tool configure

Checking configuration status...

SUCCESS: ssl configured to true. No conflicts
libvirt is already configured for vdsm
sanlock service is already configured

Running configure...

Done configuring modules to VDSM.

Comment 5 Vered Volansky 2014-05-14 04:17:41 UTC
Doc-text is actually wrong. The update removed misleading error messages that shouldn't have gotten to the user the way they did. It does not provide *more* inforamtion to the user. Bronheim, do you agree?

Comment 6 Yaniv Bronhaim 2014-05-18 13:41:52 UTC
no, the output was correct but hard to understand. this is only enhancement in stdout prints, as described in the doc-text.

Comment 7 errata-xmlrpc 2014-06-09 13:26:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0504.html