| Summary: | Review Request: libtimezonemap - Time zone map widget for Gtk+ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Shea <dshea> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, notting, package-review |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-14 18:19:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
David Shea
2013-11-13 21:22:00 UTC
1. Better use macro consistently as:
Summary: Development files for %{name}
Requires: %{name}%{?_isa} = %{version}-%{release}
%description devel
This package contains development files for
developing applications that use %{name}.
2.
Rpmlint (installed packages)
----------------------------
# rpmlint libtimezonemap libtimezonemap-devel
libtimezonemap.i686: W: spelling-error %description -l en_US datetime -> date time, date-time, daytime
libtimezonemap.i686: W: unused-direct-shlib-dependency /usr/lib/libtimezonemap.so.1.0.0 /lib/libpangocairo-1.0.so.0
libtimezonemap.i686: W: unused-direct-shlib-dependency /usr/lib/libtimezonemap.so.1.0.0 /lib/libpango-1.0.so.0
libtimezonemap.i686: W: unused-direct-shlib-dependency /usr/lib/libtimezonemap.so.1.0.0 /lib/libatk-1.0.so.0
libtimezonemap.i686: W: unused-direct-shlib-dependency /usr/lib/libtimezonemap.so.1.0.0 /lib/libcairo-gobject.so.2
libtimezonemap-devel.i686: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
# echo 'rpmlint-done:'
3. GPL (v2 or later)
-----------------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/cc-timezone-map.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/cc-timezone-map.h
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/tz.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/tz.h
GPL (v3)
--------
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/timezone-completion.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0.4.1/src/timezone-completion.h
------------------
PACKAGE APPROVED.
Can you fix 3 issues above? Or notify upstream?
(In reply to Christopher Meng from comment #1) > 1. Better use macro consistently as: > > Summary: Development files for %{name} > Requires: %{name}%{?_isa} = %{version}-%{release} > > %description devel > This package contains development files for > developing applications that use %{name}. Ok. Updated the spec and srpm on fedorapeople. > > 2. > Rpmlint (installed packages) > ---------------------------- > # rpmlint libtimezonemap libtimezonemap-devel > libtimezonemap.i686: W: spelling-error %description -l en_US datetime -> > date time, date-time, daytime Intentional, this is referring a GNOME control-center panel named "datetime" > libtimezonemap.i686: W: unused-direct-shlib-dependency > /usr/lib/libtimezonemap.so.1.0.0 /lib/libpangocairo-1.0.so.0 > libtimezonemap.i686: W: unused-direct-shlib-dependency > /usr/lib/libtimezonemap.so.1.0.0 /lib/libpango-1.0.so.0 > libtimezonemap.i686: W: unused-direct-shlib-dependency > /usr/lib/libtimezonemap.so.1.0.0 /lib/libatk-1.0.so.0 > libtimezonemap.i686: W: unused-direct-shlib-dependency > /usr/lib/libtimezonemap.so.1.0.0 /lib/libcairo-gobject.so.2 pango and cairo and other accouterments are pulled in by the gtk+ pkgconfig whether they're used or not, so this is more gtk's fault than anything. > libtimezonemap-devel.i686: W: no-documentation Yeah. I'd like this package to include some API documentation generated from doc comments, but right now there are no doc comments. Working with upstream on getting those in place. > 2 packages and 0 specfiles checked; 0 errors, 6 warnings. > # echo 'rpmlint-done:' > > > 3. GPL (v2 or later) > ----------------- > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0. > 4.1/src/cc-timezone-map.c > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0. > 4.1/src/cc-timezone-map.h > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0. > 4.1/src/tz.c > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0. > 4.1/src/tz.h > > GPL (v3) > -------- > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0. > 4.1/src/timezone-completion.c > /var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/libtimezonemap-0. > 4.1/src/timezone-completion.h > I updated the spec file to use GPLv3 as the license. I'll ask upstream if they want to change the boilerplate on the stuff inherited from GNOME to GPLv3, but since it's already v2 or later I don't think it should be an issue as-is. PACKAGE APPROVED. New Package SCM Request ======================= Package Name: libtimezonemap Short Description: Time zone map widget for Gtk+ Owners: dshea Branches: InitialCC: Git done (by process-git-requests). Package built for devel. Package Change Request ====================== Package Name: libtimezonemap New Branches: f20 Owners: dshea InitialCC: Changed my mind about it being >= f21 only, since we'd like to be able to build anaconda on F20. Sorry, thanks. Git done (by process-git-requests). |