Bug 1030304

Created attachment 823868 [details]
uptime screen shot

There does seem to be something to at least be explained.  I also see a drop but it seems to be related to a new install not yet having enough data to cover the time range of the sparkline.

Also, though, there is a disparity between the sparklines in the summary and those in the metrics list grid column.  I would expect them to look the same.

Moving into ER05 as didn't make the ER04 cut.

(In reply to Jay Shaughnessy from comment #3)
> There does seem to be something to at least be explained.  I also see a drop
> but it seems to be related to a new install not yet having enough data to
> cover the time range of the sparkline.

When a new sparkline is created it fills from the left to right and there is not enough data yet to completely cover the range of the sparkline the very first point is 0. This is why it looks to drop off at the end whenever we don't have enough data to fill the sparkline.

> 
> Also, though, there is a disparity between the sparklines in the summary and
> those in the metrics list grid column.  I would expect them to look the same.

The sparklines in the summary and the sparklines on the metrics tab can have different time periods and therefore would not look the same. The summary tab sparklines are fixed and the metrics tab sparklines are whatever the person last left them at.

Continuing to look more, but this is what I have uncovered so far.

Here is an example of the sparkline (notice the values) and the corresponding canvas elemement that is created by a jquery plugin.

<span id="sparkline_4" class="dynamicsparkline" values="49.2,37.5,28,43.75,15.428571428571429," width="0">
<canvas style="display: inline-block; width: 18px; height: 17px; vertical-align: top;" width="18" height="17"></canvas>
</span>

Got it!

There was a trailing comma in the summary sparklines that was not present in the metrics sparklines (it can be seen in the output above). That trailing comma causes the last value to default to zero until the sparkline is filled up with enough values that it doesn't matter.

Checked into master:

commit f3ecc797a741da1896578bacd00926af91b45cf7
Author: Mike Thompson <mithomps>
Date:   Thu Oct 16 15:24:23 2014 -0700

    [BZ 1030304] Incorrect last value in overview graph on resource summary page.

This also solves the inconsistency issue between summary sparklines and monitor/metric sparklines (providing they are on the same time range). See included images for this.

Created attachment 947764 [details]
Summary Metrics with fix

Created attachment 947765 [details]
Monitoring/Metrics for comparison

This shows the equality between sparklines in summary vs monitoring/metrics now.

release/jon3.3.x commit e894d4a76b16bf2da94e6d87dc3b89c05db19285
Author: Mike Thompson <mithomps>
Date:   Thu Oct 16 15:24:23 2014 -0700

    (cherry picked from commit f3ecc797a741da1896578bacd00926af91b45cf7)
    Signed-off-by: Jay Shaughnessy <jshaughn>

Moving to ON_QA as available to test with the latest brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=394734

Verified on
Version :	
3.3.0.ER05
Build Number :	
92b6d6a:2cdb528