Bug 1030537
| Summary: | Don't allow users to add iso repos to content views | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Justin Sherrill <jsherril> |
| Component: | WebUI | Assignee: | David Davis <daviddavis> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | sthirugn <sthirugn> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0.2 | CC: | bbuckingham, cwelton, jmontleo, sthirugn |
| Target Milestone: | Unspecified | Keywords: | Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://projects.theforeman.org/issues/7138 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-11 12:20:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Justin Sherrill
2013-11-14 16:15:00 UTC
While investigating bug 1129424, had some discussion with Justin and Mike about handling of ISO repos. For that bug, we have decided that it doesn't make sense to distribute ISO repos to the capsules/nodes. We also discussed this bug and the decision is that it really doesn't make sense to be add ISO repos to a content view and then publish/promote them. So to fix this bug, we should at a minimum: - not include ISO repos in the list of available repos to be added to a content view - not allow the user to add an ISO repo to a content view Looks like we already limit the UI to yum repos so I just need to add a check to the model (for the CLI): https://github.com/Katello/katello/blob/master/engines/bastion/app/assets/javascripts/bastion/content-views/details/content-view-available-repositories.controller.js#L40 Created redmine issue http://projects.theforeman.org/issues/7138 from this bug Moving to POST since upstream bug http://projects.theforeman.org/issues/7138 has been closed ------------- David Davis Applied in changeset commit:katello|e1212e9ae8343828d9045f026618c48f0d44b31a. Verified. * UI - I dont see iso repos in the content-view - add repositories page * CLI 0- Throws proper message when trying to add iso or puppet repos repoid | reponame 155 | Red Hat Enterprise Linux 6 Server ISOs i386 6.5 142 | Red Hat Enterprise Linux 6 Server ISOs x86_64 6.5 1 | Red Hat Enterprise Linux 6 Server Kickstart i386 6Server 4 | Red Hat Enterprise Linux 6 Server RPMs x86_64 6Server 152 | Red Hat Enterprise Linux 7 Server - Supplementary ISOs x86_64 7.0 78 | testrepo1 hammer> content-view add-repository --id=20 --repository-id=155 Could not add repository: Validation failed: Cannot add file repositories to a content view. hammer> content-view add-repository --id=20 --repository-id=142 Could not add repository: Validation failed: Cannot add file repositories to a content view. hammer> content-view add-repository --id=20 --repository-id=1 The repository has been associated hammer> content-view add-repository --id=20 --repository-id=4 The repository has been associated hammer> content-view add-repository --id=20 --repository-id=152 Could not add repository: Validation failed: Cannot add file repositories to a content view. hammer> content-view add-repository --id=20 --repository-id=78 Could not add repository: Validation failed: Cannot add puppet repositories to a content view. This was delivered with Satellite 6.0 which was released on 10 September 2014. |