Bug 1030834
| Summary: | [restore.sh] restore.sh is doing restore.sh.log in /usr directory | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Jiri Belka <jbelka> | |
| Component: | ovirt-engine | Assignee: | Eli Mesika <emesika> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Belka <jbelka> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 3.3.0 | CC: | acathrow, emesika, iheim, lpeer, pstehlik, Rhev-m-bugs, sbonazzo, yeylon | |
| Target Milestone: | --- | Keywords: | ZStream | |
| Target Release: | 3.4.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | infra | |||
| Fixed In Version: | ovirt-3.4.0-alpha1 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1069714 (view as bug list) | Environment: | ||
| Last Closed: | Type: | Bug | ||
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1069714, 1078909, 1142926 | |||
Another thing... The command does not drop database:
-%-
# su - postgres -c "psql -d template1 -c \"drop database engine;\""
# su - postgres
$ psql
psql (8.4.18)
Type "help" for help.
postgres=# \l
List of databases
Name | Owner | Encoding | Collation | Ctype | Access privileges
-----------+----------+----------+-------------+-------------+-----------------------
engine | engine | UTF8 | en_US.UTF-8 | en_US.UTF-8 |
postgres | postgres | UTF8 | en_US.UTF-8 | en_US.UTF-8 |
template0 | postgres | UTF8 | en_US.UTF-8 | en_US.UTF-8 | =c/postgres
: postgres=CTc/postgres
template1 | postgres | UTF8 | en_US.UTF-8 | en_US.UTF-8 | =c/postgres
: postgres=CTc/postgres
(4 rows)
ovirt 3.4.0 alpha has been released OK, beta2.
restore.sh.log was created in /var/log/ovirt-engine.
# grep restore.sh.log /tmp/restore.*
/tmp/restore.4477:open("/var/log/ovirt-engine/restore.sh.log", O_WRONLY|O_CREAT|O_APPEND, 0666) = 4
/tmp/restore.4486:open("/var/log/ovirt-engine/restore.sh.log", O_WRONLY|O_CREAT|O_APPEND, 0666) = 4
/tmp/restore.5979:open("/var/log/ovirt-engine/restore.sh.log", O_WRONLY|O_CREAT|O_APPEND, 0666) = 4
Closing as part of 3.4.0 |
Description of problem: restore.sh is doing restore.sh.log in /usr directory -%- /tmp/restore.8170:execve("/usr/bin/psql", ["psql", "-w", "--pset=tuples_only=on", "--set", "ON_ERROR_STOP=1", "--file=/tmp/tmp.5nmzHRe65M", "--dbname=engine", "--username=engine", "--host=localhost", "--port=5432", "--log-file=restore.sh.log"], [/* 22 vars */]) = 0 -%- ...which is /usr/share/ovirt-engine/dbscripts, this is not acceptable. Example run: -%- # strace -f -ff -o /tmp/restore ./restore.sh -u engine -d engine -f /root/backup.sql ...skip... # egrep "restore\.sh\.log|/tmp" /tmp/restore.82* /tmp/restore.8217:read(3, "/tmp/tmp.tkDJGIUM7T\n", 128) = 20 /tmp/restore.8217:open("/tmp/tmp.tkDJGIUM7T", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 3 /tmp/restore.8219:open("/tmp/tmp.tkDJGIUM7T", O_RDWR|O_CREAT|O_EXCL, 0600) = 3 /tmp/restore.8219:write(1, "/tmp/tmp.tkDJGIUM7T\n", 20) = 20 /tmp/restore.8220:execve("/usr/bin/psql", ["psql", "-w", "--pset=tuples_only=on", "--set", "ON_ERROR_STOP=1", "--file=/tmp/tmp.tkDJGIUM7T", "--dbname=template1", "--username=engine", "--host=localhost", "--port=5432", "--log-file=restore.sh.log"], [/* 29 vars */]) = 0 /tmp/restore.8220:open("restore.sh.log", O_WRONLY|O_CREAT|O_APPEND, 0666) = 4 /tmp/restore.8220:open("/tmp/tmp.tkDJGIUM7T", O_RDONLY) = 5 /tmp/restore.8222:execve("/bin/rm", ["rm", "/tmp/tmp.tkDJGIUM7T"], [/* 29 vars */]) = 0 /tmp/restore.8222:newfstatat(AT_FDCWD, "/tmp/tmp.tkDJGIUM7T", {st_mode=S_IFREG|0600, st_size=62, ...}, AT_SYMLINK_NOFOLLOW) = 0 /tmp/restore.8222:unlinkat(AT_FDCWD, "/tmp/tmp.tkDJGIUM7T", 0) = 0 /tmp/restore.8226:read(3, "/tmp/tmp.NzrEN0ZeJR\n", 128) = 20 /tmp/restore.8226:open("/tmp/tmp.NzrEN0ZeJR", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 3 /tmp/restore.8228:open("/tmp/tmp.NzrEN0ZeJR", O_RDWR|O_CREAT|O_EXCL, 0600) = 3 /tmp/restore.8228:write(1, "/tmp/tmp.NzrEN0ZeJR\n", 20) = 20 /tmp/restore.8229:execve("/usr/bin/psql", ["psql", "-w", "--pset=tuples_only=on", "--set", "ON_ERROR_STOP=1", "--file=/tmp/tmp.NzrEN0ZeJR", "--dbname=engine", "--username=engine", "--host=localhost", "--port=5432", "--log-file=restore.sh.log"], [/* 29 vars */]) = 0 /tmp/restore.8244:read(3, "/tmp/tmp.FvPeWijFOs\n", 128) = 20 /tmp/restore.8244:open("/tmp/tmp.FvPeWijFOs", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 3 /tmp/restore.8246:open("/tmp/tmp.FvPeWijFOs", O_RDWR|O_CREAT|O_EXCL, 0600) = 3 /tmp/restore.8246:write(1, "/tmp/tmp.FvPeWijFOs\n", 20) = 20 /tmp/restore.8247:execve("/usr/bin/psql", ["psql", "-w", "--pset=tuples_only=on", "--set", "ON_ERROR_STOP=1", "--file=/tmp/tmp.FvPeWijFOs", "--dbname=engine", "--username=engine", "--host=localhost", "--port=5432", "--log-file=restore.sh.log"], [/* 29 vars */]) = 0 # ls -l restore.sh.log -rw-r--r--. 1 root root 126 Nov 15 10:24 restore.sh.log -%- Version-Release number of selected component (if applicable): is23 How reproducible: 100% Steps to Reproduce: 1. run restore.sh 2. check if restore.sh.log exists in /usr dir and it is recent 3. Actual results: log in /usr dir Expected results: 1. /usr is not place for logs, 2. will we have such logs place all around whole system? Additional info: /var/log/ovirt-engine ... somewhere there would be good place?