Bug 1030968

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6190605

$ rpmlint -i -v *python3-micawber.noarch: I: checking
python3-micawber.noarch: W: spelling-error Summary(en_US) urls -> curls, purls, hurls
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds)
python3-micawber.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/examples/django_ex/manage.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-micawber.noarch: E: zero-length /usr/lib/python3.3/site-packages/micawber/contrib/mcdjango/mcdjango_tests/models.py
python3-micawber.noarch: E: zero-length /usr/lib/python3.3/site-packages/micawber/contrib/mcdjango/models.py
python-micawber.noarch: I: checking
python-micawber.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
The value of this tag appears to be misspelled. Please double-check.

python-micawber.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube
The value of this tag appears to be misspelled. Please double-check.

python-micawber.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
The value of this tag appears to be misspelled. Please double-check.

python-micawber.noarch: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds)
python-micawber.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/examples/django_ex/manage.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-micawber.noarch: E: zero-length /usr/lib/python2.7/site-packages/micawber/contrib/mcdjango/mcdjango_tests/models.py
python-micawber.noarch: E: zero-length /usr/lib/python2.7/site-packages/micawber/contrib/mcdjango/models.py
python-micawber.src: I: checking
python-micawber.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
The value of this tag appears to be misspelled. Please double-check.

python-micawber.src: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube
The value of this tag appears to be misspelled. Please double-check.

python-micawber.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
The value of this tag appears to be misspelled. Please double-check.

python-micawber.src: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds)
python-micawber.src:56: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:56: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:56: W: macro-in-comment %{__python2}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:57: W: macro-in-comment %{py3dir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:58: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:58: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:58: W: macro-in-comment %{__python3}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src: I: checking-url https://pypi.python.org/packages/source/m/micawber/micawber-0.3.0.tar.gz (timeout 10 seconds)
python-micawber.spec:56: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:56: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:56: W: macro-in-comment %{__python2}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:57: W: macro-in-comment %{py3dir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:58: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:58: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:58: W: macro-in-comment %{__python3}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec: I: checking-url https://pypi.python.org/packages/source/m/micawber/micawber-0.3.0.tar.gz (timeout 10 seconds)
3 packages and 1 specfiles checked; 6 errors, 24 warnings.

Please fix the file headers. We don't use the "env" style anymore, and scripts in %{python?_sitelib} don't use shebangs at all.

Escape the macros in the comments in the %check section to avoid unexpected behavior.

"urls" is a terrible construct. Use "URLs" instead.

Have a look at the test scripts. I don't assume that we really need empty files, unless they serve as placeholders for something. Otherwise, remove them.

This is un-official review of the package:

I'm not able to find the SRPM, the link is broken.

fedora-review -b 1030968
INFO: Processing bugzilla bug: 1030968
INFO: Getting .spec and .srpm Urls from : 1030968
INFO:   --> SRPM url: http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm
INFO:   --> Spec url: http://cicku.me/python-micawber.spec
INFO: Using review directory: /tmp/1030968-python-micawber
INFO: Downloading .spec and .srpm files
ERROR: 'Error 404 downloading http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm' (logs in /home/sac/.cache/fedora-review.log)

The spec file does not exist for more than three years and the submitter did not fix it. Closing this review

(In reply to Petr Pisar from comment #5)
> The spec file does not exist for more than three years and the submitter did
> not fix it. Closing this review

Actually the package is already in Fedora:
https://bugzilla.redhat.com/show_bug.cgi?id=1718682

At the time that I have submitted the package I was not aware of this review.

*** This bug has been marked as a duplicate of bug 1718682 ***