| Summary: | Review Request: glacier-cli - Command-line interface to Amazon Glacier | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hadfieldster, i, notting, package-review, robie.basak |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glacier-cli-0-8.20131113gite8a2536.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-05 10:27:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Miroslav Suchý
2013-11-15 13:39:45 UTC
Just another question here: I'm packaging aws-cli now, are you doing that also? Take this one. Nope. Even python-boto have command line interface to Glacier. But it is very simple. Glacier-cli is much better and user friendly. 1. Please escape:
glacier-cli.src:12: W: macro-in-comment %{githash}
glacier-cli.src:12: W: macro-in-comment %{name}
glacier-cli.src:12: W: macro-in-comment %{githash}
2. env stuffs:
Requires
--------
glacier-cli (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/env
python-boto
python-sqlalchemy
Please patch #!/usr/bin/env python in glacier.py to %{python2}
Others are fine.
> 1. Please escape: Hmm, I thought that having it *not* escaped in comment is correct in this case as it will evaluate to exact correct string, which needs to be executed to get SOURCE0 for that specific version. But as you like. Changed. > 2. env stuffs: Changed. Spec URL: http://miroslav.suchy.cz/fedora/glacier-cli/glacier-cli.spec SRPM URL: http://miroslav.suchy.cz/fedora/glacier-cli/glacier-cli-0-5.20131113gite8a2536.fc20.src.rpm PACKAGE APPROVED. Thanks. New Package SCM Request ======================= Package Name: glacier-cli Short Description: Command-line interface to Amazon Glacier Owners: msuchy Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). > 1. Please escape:
The macros here didn't cause any problems, so escaping them does not improve anything. See output of "rpmlint -i ..." which prints Help text about reported warnings and errors.
It is okay to keep them unescaped.
glacier-cli-0-7.20131113gite8a2536.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/glacier-cli-0-7.20131113gite8a2536.el6 glacier-cli-0-7.20131113gite8a2536.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/glacier-cli-0-7.20131113gite8a2536.fc20 glacier-cli-0-7.20131113gite8a2536.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/glacier-cli-0-7.20131113gite8a2536.fc19 glacier-cli-0-7.20131113gite8a2536.fc20 has been pushed to the Fedora 20 testing repository. Just installed the package from updates-testing for fc19 and I think you're missing a dependency:
$ glacier-cli
Traceback (most recent call last):
File "/bin/glacier-cli", line 37, in <module>
import iso8601
ImportError: No module named iso8601
Installing python-iso8601.noarch fixes the problem.
Sorry, I should have looked at the spec first. python-iso8601 needs to be a full requirement, not just a build requirement. Fixed. Thanks for reporting, but please next time do not recycle bug report and file new one. glacier-cli-0-8.20131113gite8a2536.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/glacier-cli-0-8.20131113gite8a2536.el6 glacier-cli-0-8.20131113gite8a2536.fc19 has been pushed to the Fedora 19 stable repository. glacier-cli-0-8.20131113gite8a2536.el6 has been pushed to the Fedora EPEL 6 stable repository. glacier-cli-0-8.20131113gite8a2536.fc20 has been pushed to the Fedora 20 stable repository. |